Skip to content

Commit 6366a2a

Browse files
committed
Add minimal code to make the python tests pass
Adds default parameter value for isArchivable function to bindings. This is not matching the behaviour of the C++ API. Signed-off-by: Kevin Wheatley <[email protected]>
1 parent e95304e commit 6366a2a

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/bindings/python/PyConfig.cpp

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -890,13 +890,18 @@ void bindPyConfig(py::module & m)
890890
DOC(Config, setProcessorCacheFlags))
891891

892892
// Archiving
893-
.def("isArchivable", &Config::isArchivable, DOC(Config, isArchivable))
893+
.def("isArchivable", [](ConfigRcPtr & self, bool minimal)
894+
{
895+
return self->isArchivable(minimal);
896+
},
897+
py::arg("minimal") = false,
898+
DOC(Config, isArchivable))
894899
.def("archive", [](ConfigRcPtr & self, const char * filepath)
895900
{
896901
std::ofstream f(filepath, std::ofstream::out | std::ofstream::binary);
897902
self->archive(f, ARCHIVE_FLAGS_DEFAULT); // TODO: pass flags in rather than default
898903
f.close();
899-
},
904+
},
900905
DOC(Config, archive))
901906

902907
// Conversion to string

0 commit comments

Comments
 (0)