Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocioview: Chromaticity inspector #1879

Open
michdolan opened this issue Oct 6, 2023 · 2 comments
Open

ocioview: Chromaticity inspector #1879

michdolan opened this issue Oct 6, 2023 · 2 comments
Labels
Python Issues that involve majority python development (vs C++). Tools Issues related to auxiliary OCIO tools (ex. ocioview, ociocheck)

Comments

@michdolan
Copy link
Collaborator

michdolan commented Oct 6, 2023

ocioview currently has inspectors for curves (#1845 ) and color volumes ( #1875 ).

This task would involved building a QGraphicsScene or OpenGL viewport which displays an interactive CIE chromaticity diagram, and plots the primaries of the currently viewed transform (if known) as a triangle, with the option to scatter plot all or some of the current image's transformed pixels into their xy coordinates over the diagram.

@michdolan michdolan added Size-L Python Issues that involve majority python development (vs C++). labels Oct 6, 2023
@KelSolaar
Copy link
Contributor

Hello,

I have done that with Vispy a few years ago: colour-analysis

and another similar variant with threejs: colour-analysis-three.js, https://www.colour-science.org:8020
image

I was actually rewriting colour-analysis using WebGPU via pygfx:
image

which brings me to the following question and point:

  • Is there an interest consolidating forces and having me contributing some of my code and continuing in ocioview? This would probably add some more dependencies, e.g. Colour, Pygfx, wgpu-py, etc...
  • OpenGL is on the way out, and I'm thinking that it would be future proof to embrace Vulkan and Metal via WebGPU.

Cheers,

Thomas

@michdolan
Copy link
Collaborator Author

That awesome @KelSolaar ! I think it would be great to consolidate these projects. I have no objections to introducing new Python package dependencies for ocioview. I used Qt3D for #1875 , but could see that being moved to another GPU implementation too.

@carolalynn carolalynn added Tools Issues related to auxiliary OCIO tools (ex. ocioview, ociocheck) and removed Size-L labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Issues that involve majority python development (vs C++). Tools Issues related to auxiliary OCIO tools (ex. ocioview, ociocheck)
Projects
None yet
Development

No branches or pull requests

3 participants