Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow FileTransforms from ICC profile to not clamp #1915

Open
SRHMorris opened this issue Dec 4, 2023 · 0 comments
Open

Allow FileTransforms from ICC profile to not clamp #1915

SRHMorris opened this issue Dec 4, 2023 · 0 comments
Labels
Needs Discussion Needs discussion before implmentation, which could result in changes, or a decision not to proceed.

Comments

@SRHMorris
Copy link

SRHMorris commented Dec 4, 2023

In some cases I need to have some form of interop with ICC profiles. I'm currently creating a FileTransform with the ICC profile and adding it as a scene referred color space in my config (converting reference space to ACES2065-1 and using the builtin transform for to convert to XYZ D65).

The problem is that FileFormatICC.cpp adds RangeOps to clamp the color components to be less than 1. According to comments this is because the ICC spec specifies the transfer functions operate in the range 0 to 1. However this makes these transforms fairly useless for anything except as part of a display transform.

Similarly to CDL having the style option to not clamp, it would be very useful to have the option to disable this clamping for ICC profiles. Similarly it seems like it clamps to zero for a simple power curve, it would be nice to be able to specify negative behaviour (such as mirroring around zero (sign(x) * pow(abs(x), y)).

A pretty common case for me is having the ICC profile describe a just a matrix transform (a linear space). In that case the clamp serves no purpose at all.

Originally this issue was about allowing the display created from an ICC profile to be extended range. I still think that would be useful, but it seems like the underlying issue is the RangeOps added to the FileTransform.

@SRHMorris SRHMorris changed the title Allow displays instantiated from an ICC profile to be extended range Allow FileTransforms from ICC profile to not clamp Dec 11, 2023
@carolalynn carolalynn added the Needs Discussion Needs discussion before implmentation, which could result in changes, or a decision not to proceed. label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion Needs discussion before implmentation, which could result in changes, or a decision not to proceed.
Projects
None yet
Development

No branches or pull requests

2 participants