Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BT.2100 HLG OETF as a BuiltinTransform #1969

Open
nick-shaw opened this issue Apr 26, 2024 · 2 comments
Open

Add BT.2100 HLG OETF as a BuiltinTransform #1969

nick-shaw opened this issue Apr 26, 2024 · 2 comments
Assignees
Labels
Feature Request New addition to OCIO functionality. help wanted Issues that the TSC has decided are worth implementing, but don't currently have the dev resources. Needs Discussion Needs discussion before implmentation, which could result in changes, or a decision not to proceed.
Milestone

Comments

@nick-shaw
Copy link

There is already a built-in CURVE - LINEAR_to_ST-2084 transform, but no HLG curve exists. Only DISPLAY - CIE-XYZ-D65_to_REC.2100-HLG-1000nit which, being display-referred cannot be used for scene light conversions to and from HLG. As per #1968, this curve should be mirrored about zero.

@carolalynn carolalynn added Feature Request New addition to OCIO functionality. help wanted Issues that the TSC has decided are worth implementing, but don't currently have the dev resources. labels Apr 29, 2024
@carolalynn carolalynn added the Needs Discussion Needs discussion before implmentation, which could result in changes, or a decision not to proceed. label May 15, 2024
@doug-walker doug-walker added this to the OCIO 2.4.0 milestone Jul 20, 2024
@doug-walker
Copy link
Collaborator

@nick-shaw could you please review PR #2029 to make sure the math is what you expect?

(Note that we decided to do it as a FixedFunction rather than a Builtin, but either one should work for you.)

@nick-shaw
Copy link
Author

Thanks @doug-walker . I'm not fully au fait with reading C++ code, but as far as I can tell the maths for mirroring the HLG OETF seems correct. In order to support negative values through the HLG EOTF, the OOTF also needs to include mirroring. Is that already the case? I couldn't see a change to that in that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New addition to OCIO functionality. help wanted Issues that the TSC has decided are worth implementing, but don't currently have the dev resources. Needs Discussion Needs discussion before implmentation, which could result in changes, or a decision not to proceed.
Projects
None yet
Development

No branches or pull requests

4 participants