Upgrade gradle to 7.6.2 and fix sonarqube pipeline #1393
Conversation
DiegoTavares
force-pushed
the
fix-sonar-pipeline
branch
from
a809b64
to
5c6a0c0
Compare
DiegoTavares
force-pushed
the
fix-sonar-pipeline
branch
from
5c6a0c0
to
008be39
Compare
|
This looks like the error? For a new JRE, that probably means using a new image? Yeah, that image we're using is pretty old now: |
|
Change the status to Draft! |
DiegoTavares
force-pushed
the
fix-sonar-pipeline
branch
4 times, most recently
from
427cdfa
to
6a258c1
Compare
DiegoTavares
force-pushed
the
fix-sonar-pipeline
branch
8 times, most recently
from
b25116d
to
67cd97b
Compare
DiegoTavares
force-pushed
the
fix-sonar-pipeline
branch
from
67cd97b
to
39d96fa
Compare
|
I've tried updating the base image to I've also updated target and source compatibility versions to 11 and tested multiple versions around My take is that some other dependency is bringing a newer version of @bcipriano Can you give this a go? It is a blocker for our next release. |
|
I see that the I don't know which version of I'm guessing that system-wide sonar is what's causing the problem here since changing the plugin version appears to have no effect. This doc looks relevant, it talks about JRE auto-provisioning and how to switch between versions of the JVM: https://docs.sonarsource.com/sonarcloud/appendices/scanner-environment/#maven-gradle I tried a few things to get this working:
My work is in https://github.com/AcademySoftwareFoundation/OpenCue/pull/1515/files Some other things to explore here:
|
|
I don't think this issue is being caused by the external My next attempt is to upgrade gradle. |
Upgrading gradle solved the dependency issue on the sonarqube step on the cicd pipeline.
DiegoTavares
force-pushed
the
fix-sonar-pipeline
branch
2 times, most recently
from
c8d0f5b
to
d64ba2a
Compare
DiegoTavares
force-pushed
the
fix-sonar-pipeline
branch
from
d64ba2a
to
d6b773a
Compare
DiegoTavares
force-pushed
the
fix-sonar-pipeline
branch
from
d6b773a
to
a059f03
Compare
DiegoTavares
changed the title
Ideally the `ci-opencue` image could be built with the correct version of the java jdk, but for now we're updating the version before running the pipeline to confirm it really works. The only way to confirm this works as expected is merging to master as secret-keys are not shared with pipelines triggered by PRs.
|
Alright, I think I finally got it to work. In summary:
The pipeline will only be triggered when merged to master, running it on this PR got me to a failure in trying to sign into sonar-cloud, which is expected as the SONAR_TOKEN secret is not shared with PRs. FYI @bcipriano |
| chown -R aswfuser:aswfgroup . | ||
| su -c "cd cuebot && ./gradlew jacocoTestReport sonarqube -Dsonar.login=$(SONAR_TOKEN)" aswfuser | ||
| su -c "cd cuebot && ./gradlew jacocoTestReport sonar aswfuser |
There was a problem hiding this comment.
I think there's a missing quote here. Also, we don't need to define the sonar token?
There was a problem hiding this comment.
Oops. Fixed the missing quote.
According to the documentation, having SONAR_TOKEN defined as an environment variable is supposed to be enough. Let's see when it makes it to master where we can actually test.
cuebot/build.gradle
Outdated
| sourceCompatibility = 1.8 | ||
| targetCompatibility = 1.8 | ||
| sourceCompatibility = 11 | ||
| targetCompatibility = 11 | ||
|
|
||
| ext { | ||
| activemqVersion = '5.12.0' |
There was a problem hiding this comment.
nit: Can this use def like grpc / protobuf use now?
There was a problem hiding this comment.
I guess so. I've updated on the last commit to give it a go.
the
sonarqubepipeline requires a newer version of the jvm and that's a good excuse for upgrading gradle on the project as the version we have currently is very old.