-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Exif and XML metadata support for JPEG XL #4310
Conversation
Signed-off-by: Vlad (Kuzmin) Erium <[email protected]>
Signed-off-by: Vlad (Kuzmin) Erium <[email protected]>
You're getting build failures on Mac because of an unused variable warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a couple very minor style suggestions for clarity.
Also, there is a warning failure for clang related to not using the return value of save_metadata.
But other than those, LGTM!
Can you incorporate someting into the jxl tests so that the testsuite verifies writing and reading of metadata?
Signed-off-by: Vlad (Kuzmin) Erium <[email protected]>
@lgritz I'll check how can add something to tests. But at this moment only writing was added. I also need change a docs a bit |
Signed-off-by: Vlad (Kuzmin) Erium <[email protected]>
Signed-off-by: Vlad (Kuzmin) Erium <[email protected]>
@lgritz don't know how to do a tests without implementing exif for import. |
No prob, we can just remember to add tests when the input support is added. |
@ssh4net This LGTM except for the CI failure that appears to not like 'const' in the struct definition for BoxInfo. Also, would you mind rebasing on top of the current main just to be sure there aren't any conflicts? After those two items, I'm good to merge this. |
Signed-off-by: Vlad (Kuzmin) Erium <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description
Initial Exif and XML metadata support for JPEG XL.
EXIF - works and enabled by default
XML - works and enabled by default
IPTC - that part need some help. JPEG XL support XML based IPTC, but I do not get what IPTC create an OIIO
JBIG - not sure
new options:
jpegxl:use_boxes
- export EXIF, XMP, IPTC, JBIGjpegxl:compress_boxes
- compress meta boxes (disabled for this moment by default)jpegxl:exif_box = 1 (enabled)
jpegxl:xmp_box = 1 (enabled)
jpegxl:jumb_box = 0 (disabled)
jpegxl:iptc_box = 0 (disabled)
Tests
Not yet, but if we have I can add.
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.