Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz normal when layered on top of coat #107

Open
brechtvl opened this issue Oct 5, 2023 · 3 comments
Open

Fuzz normal when layered on top of coat #107

brechtvl opened this issue Oct 5, 2023 · 3 comments

Comments

@brechtvl
Copy link
Contributor

brechtvl commented Oct 5, 2023

Coat uses geometry_coat_normal, while other layers including fuzz use geometry_normal. Now that fuzz is on top of coat, this may no longer be correct.

Consider a material with a bumpy base layer, and a smooth coat layer on top that fills in the bumps. The fuzz should then have a smooth normal as well?

A solution could be to blend geometry_normal and geometry_coat_normal with coat_weight, and use that as the fuzz normal?

@virtualzavie
Copy link
Contributor

Thank you for pointing this out.

We could describe that the fuzz uses the normal of the layer underneath.
In the case of partial coverage, that would be a blend of two fuzz lobes using normal from the base and coat layers. It would be expensive to evaluate, but implementations could approximate by "blending" normals.

@portsmouth
Copy link
Contributor

Pushed a PR for this: #117

@portsmouth
Copy link
Contributor

Can be closed, addressed in #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants