Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For consistency, every section should have a "weight" parameter. #134

Open
ZapAndersson opened this issue Oct 30, 2023 · 2 comments
Open

Comments

@ZapAndersson
Copy link

While working on the UI for 3ds max, I realize how inconsistent it feels that everything has a weight, except emission and thin film.

I think everything should have a weight, even though this is just a multiplier in the case of emission and thin film, the UI consistency and the ease of explaining the functionality wins out, IMHO.

Also, since both thin-film thickness and emission luminance quite often have values outside the easily texturable 0-1 range, it is extremely convenient to be able to set e.g. a high luminance value, but then modulate the intensity of the light by a 0-1 weight map, or to set a given thin-film thickness, and modulate the coverage of the thin film with a 0-1 weight map.

The only reason not to have them is parameter count frugality, but if most real-world use cases has users plugging in multiplier nodes in front of these all the time, I feel that feature should be built in.

@andre-ilm
Copy link

andre-ilm commented Nov 11, 2023

Edit:
Just realised this would have been better said in #76.

I'd like to hear more about the reasoning for weights everywhere. For our internal proprietary shaders we took the opposite approach for a few reasons:

  • Fewer maps (can be critical for GPUs)
  • Singular controls (don't have more than one way to do the same thing)
  • An external shader graph can provide this control if necessary

@portsmouth
Copy link
Contributor

Just to note that having a thin_film_weight would I think be a genuine improvement to the model, as currently there is no way to dial the strength of the effect without altering the colors and banding (as the thickness alters those things, as well as the saturation of the color tinting).

It would be trivial to implement (in the spec and in software) as effectively the presence/coverage weight of the thin film layer.

jstone-lucasfilm pushed a commit that referenced this issue May 7, 2024
This addresses the following:

- Implementing thin-film interference in combination with F82-tint metallic Fresnel #79
- For consistency, every section should have a "weight" parameter. #134
- Thin film in micrometers divided by 2 for normalized parameter range #150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants