Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Fuzz/sheen can darken as well as lighten #176

Open
sharktacos opened this issue Apr 29, 2024 · 3 comments
Open

Proposal: Fuzz/sheen can darken as well as lighten #176

sharktacos opened this issue Apr 29, 2024 · 3 comments

Comments

@sharktacos
Copy link

sharktacos commented Apr 29, 2024

I’d like to propose that it would be nice if the fuzz/sheen parameter was able to darken as well as lighten. Many surface appearances such as nylon stockings, denim jeans, and silk all appear darker on the glancing angle rather than lighter.

Offering this as a topic for discussion.

@peterkutz
Copy link
Contributor

Hi @sharktacos , I agree that being able to make dark fuzz would be very useful. I also raised this concern a while back and we actually already included this capability in the spec.

Currently the spec only mentions this indirectly as part of the math and this statement:

The microflake fibers are assumed to have a single-scattering albedo that effectively produces a reflection tinted with the fuzz_color after multiple scattering.

For this issue, I would suggest that we add a sentence to the spec to explicitly say that you can make dark fuzz as well as light fuzz.

@sharktacos
Copy link
Author

Echoing @peterkutz I have tested, darkening with fuzz in the web viewer, and indeed it works splendidly. So it would simply be a matter of noting this existing feature in the documentation.

@portsmouth
Copy link
Contributor

portsmouth commented May 28, 2024

Just to note, I think it's arguably a slight defect of the Zeltner model that it doesn't explicitly model the color of the fuzz, i.e. one has to add it "artifically" as an overall tint. So it can't really be said to actually model the multiple scattering between colored fibres.

Also it seems arbitrary to me that the optical depth was fixed at 1. So room for improvement..

jstone-lucasfilm pushed a commit that referenced this issue Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants