formats.gto and movieformats.gto are not correctly made.

[richardssam]

Hi, I'm building on windows with a fresh install. It all builds correctly, although it does require two times to do the first build.

However, once I launch rv.exe I find that only a very basic set of formats are supported like .sgi

The problem appears to be that the formats.gto file and movieformats.gto file are not correctly made, and end up at about 1k in size (rather than > 5K in the commercial RV format). I found that simply copying over these files from the commercial version seems to fix it.

I havent quite figured out where these files are being built yet.

[richardssam]

I think I found what needs to be run:
cd \OpenRV_install\bin
.\makeMovieIOformats.exe ..\PlugIns\MovieFormats
.\makeFBIOformats.exe ..\PlugIns\ImageFormats\

I suspect its being run from the wrong directory.

[bernie-laberge]

Thanks for reporting this @richardssam,

I'll try to reproduce this issue later today with an Open RV build from scratch.
I'll report back.

Note that as you probably know, Open RV has fewer supported movie formats than the commercial RV when building OpenRV without any modifications. That's because only the royalty free codecs are included by default in Open RV:

OpenRV/cmake/dependencies/ffmpeg.cmake

Line 197 in 950ec03

LIST(APPEND _disabled_decoders "--disable-decoder=bink")

But still, the movieformats.gto should be around 12KB (as opposed to 14KB for the commercial RV).
I will look into this and report back. Thanks!

[richardssam]

What was generated seemed to be 1k. Just out of curiosity, is this file still necessary? And/or would it make sense as json or yaml? gto isnt a terribly common format ;) Sam

…

On Mon, 27 May 2024 at 13:59, Bernard Laberge ***@***.***> wrote: Thanks for reporting this @richardssam <https://github.com/richardssam>, I'll try to reproduce this issue later today with an Open RV build from scratch. I'll report back. Note that as you probably know, Open RV has fewer supported movie formats than the commercial RV when building OpenRV without any modifications. That's because only the royalty free codecs are included by default in Open RV: https://github.com/AcademySoftwareFoundation/OpenRV/blob/950ec03afeefa4a0ead147adae8ec685fbee9753/cmake/dependencies/ffmpeg.cmake#L197 But still, the movieformats.gto should be around 12KB (as opposed to 14KB for the commercial RV). I will look into this and report back. Thanks! — Reply to this email directly, view it on GitHub <#472 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2TR2G3IN5H3A76MLPDD5LZEMUZJAVCNFSM6AAAAABIJBA3TCVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TKNZQGI2DG> . You are receiving this because you were mentioned.Message ID: <AcademySoftwareFoundation/OpenRV/repo-discussions/472/comments/9570243@ github.com>

[bernie-laberge]

I am not sure why. My guess is that the original RV creators decided to use such a file for security purpose or something to make sure that only the codecs appearing in the list were loaded?
It also doesn't help that the content of the file is compressed (Writer::CompressedGTO)

To debug it in the past, I have often changed it from Writer::CompressedGTO to Writer::TextGTO here:

OpenRV/src/bin/imgtools/makeMovieIOformats/main.cpp

Line 98 in 0ba6a73

if (!writer.open(outfile.c_str(), Writer::CompressedGTO))

[bernie-laberge]

FYI: I just rebuilt from scratch the latest Open RV commit on my Windows system and it built without errors. (Typical it works on my system answer sorry!).
When I get the chance this week, I will use a brand new windows machine and reinstall everything from scratch. Sometimes MSYS2 gets updated and it can cause issues with the Open RV build. You might be experiencing that...

[richardssam]

This was the only error I got, so the build process is definitely getting much better. Also this error is also pretty easy to recover from, once you know the trick. Thanks again for looking into it. Sam

…

On Tue, Jun 4, 2024 at 3:38 PM Bernard Laberge ***@***.***> wrote: FYI: I just rebuilt from scratch the latest Open RV commit <0ba6a73> on my Windows system and it built without errors. (Typical it works on my system answer sorry!). When I get the chance this week, I will use a brand new windows machine and reinstall everything from scratch. Sometimes MSYS2 gets updated and it can causes issues with the Open RV build. You might be experiencing that... — Reply to this email directly, view it on GitHub <#472 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2TR2B6ZR6LRRNTTX6ZJADZFXGOZAVCNFSM6AAAAABIJBA3TCVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4TMNRVHA4DG> . You are receiving this because you were mentioned.Message ID: <AcademySoftwareFoundation/OpenRV/repo-discussions/472/comments/9665883@ github.com>