Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: OpenJpeg missing from windows build #595

Closed
1 task done
richardssam opened this issue Sep 24, 2024 · 4 comments
Closed
1 task done

[Bug]: OpenJpeg missing from windows build #595

richardssam opened this issue Sep 24, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@richardssam
Copy link
Contributor

What happened?

I'm unable to open j2c or j2k files in openRV, even though the library is built. I suspect there is a build error, since while I see the library being built, it doesnt seem to be installed.

List all the operating systems versions where this is happening

windows 10

On what computer hardware is this happening?

thinkpad

Relevant console log output

No response

Environment variables

No response

Extra information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@richardssam richardssam added the bug Something isn't working label Sep 24, 2024
cedrik-fuoco-adsk added a commit that referenced this issue Sep 26, 2024
### OpenJPEG is not compiled on Windows

### Linked issues
#595 

### Summarize your change.
Make sure that OpenJPEG builds on Windows is triggered.

### Describe the reason for the change.
The build of OpenJPEG was not triggered on Windows and OIIO was not
loading OpenJPEG on Windows.

### Describe what you have tested and on which operating system.
I tested with a j2k image on Windows and it is working now.

Signed-off-by: Cédrik Fuoco <[email protected]>
@cedrik-fuoco-adsk
Copy link
Contributor

@richardssam I tested with some J2k files and they are displayed. Could you re-build Open RV from main and confirm that it works for you? Thanks!

@richardssam
Copy link
Contributor Author

richardssam commented Sep 26, 2024 via email

@cedrik-fuoco-adsk
Copy link
Contributor

Sorry, I wasn't clear. There was an issue. I just merged the PR that fix the issue. #596 @richardssam

@richardssam
Copy link
Contributor Author

Thanks, that makes me feel much better ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants