New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imath includes shall be guarded #1582

Open

sanguinariojoe opened this issue Oct 17, 2023 · 1 comment

Labels

Contributor

sanguinariojoe commented Oct 17, 2023 •

edited

Loading

You are many times doing dangerous includes:

https://github.com/AcademySoftwareFoundation/openexr/blob/main/src/lib/OpenEXRCore/internal_coding.h#L24

While you should do the guarded version:

#include <Imath/half.h>

There are 2 main reasons that make your way suboptimal:

Collisions. How many projects can have a half.h header file? Any other project with such a file, which is either not guarding the header or including it like you do, will cause a collision
Exotic makefiles. With CMake this is not a big deal (or maybe it is...), but it is definitely a pain in the ass on other building systems. It is indeed impossible to use Imath when installed on a custom folder.

The text was updated successfully, but these errors were encountered:

meshula added the Enhancement label

Contributor

meshula commented Oct 20, 2023

That would be a good thing to address, thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment