fix example #1714
fix example #1714
Conversation
|
|
and raise error when running the buggy version instead of python mysteriously crashing fixes AcademySoftwareFoundation#1711 Signed-off-by: Heshy Roskes <[email protected]>
|
I'm trying to figure out who from my institution I should reach out to about the CLA. I'm hoping to get back to you about that later today. |
|
Also, I'm pretty sure the doctest is way outdated and not used anymore (it still has python 2 print), but I figured I'd update it anyway and you can use it if you ever decide to turn those back on. |
There was a problem hiding this comment.
Thanks for the fix, both for the example code and the error handling. We recently inherited this code, and it's indeed quite old. We're working on an upgrade, but it's good to have it fixed in the meantime.
I'll merge as soon as you can complete the CLA. Thanks again!
|
@hroskes, will you be able to sign the CLA? I'd like to merge this if you can. If it's too much of a hassle I can make the fix independently. Thanks! |
|
I'm sorry, I'm working on it! There should be a trivial procedure to deal with trivial changes like this one, and there probably is but I'm having trouble figuring out what that is. Still iterating with the people at my institution. |
|
@cary-ilm We got the CLA signed. Thanks so much and I'm sorry for the long delay! |
and raise error when running the buggy version
instead of python mysteriously crashing
fixes #1711