-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel install target #1730
Comments
@tiago-lqt Feel free to add a You can easily add
I have no experience with Rust bindings. Put adding a |
I've made some progress in setting up a new Unfortunately I've hit a blocker with dependencies.
Does this means we would have to update and publish a new Imath version that updates |
@tiago-lqt
|
You're right. I've misread the build files. And thanks to your suggestion managed to get around the issue, but still believe there is a visibility issue. For context the following comes from testing in the v3.2.4 tag at a1a00ff. I wrote half this comment and then went to test at head and noticed the files in question were removed. Which I've tracked for a commit after that release in ad9d698. If you see the patch file the action Of course the files in question are no longer in the repo, but this test might mean the file patch you've linked might have to be updated. |
If you tell me what I should add there I can add it ;) Maybe something like
is needed. Not sure about this... Can you open a PR with your changes (e.g. in Draft Mode)? Then its easier for me to see the same error... |
I've pushed a sample commit to my fork. tiago-lqt@5965704 . Note that the commit is the one raising the error:
and if I change the path being used to
To clarify, the rule where I've added the public visibility is the I'm guessing that adding this snippet around line 27 of that patch file would solve the issue.
|
|
For 1. its likely due to trying different options. Both were erroring out but I'll switch to PR looks good, thanks for setting it up! |
Patch imath - this patch makes ImathConfig.h public. This is needed for rust binding -> AcademySoftwareFoundation/openexr#1730
@tiago-lqt bazelbuild/bazel-central-registry#1953 is merged now. |
Patch imath - this patch makes ImathConfig.h public. This is needed for rust binding -> AcademySoftwareFoundation/openexr#1730
Patch imath - this patch makes ImathConfig.h public. This is needed for rust binding -> AcademySoftwareFoundation/openexr#1730
Let me start by thanking all the hard work supporting this build flow. Overall the experience is much better than I've had previously with cmake, particularly on windows where I'm using it atm.
I'm planning on using the OpenEXR library and headers outside of the bazel build toolchain, in concrete development of bindings for rust, and because of this I need some sort of install target, which afaik is not supported yet.
Having poked a bit at bazel seems like it would be possible to add a
pkg_tar
rule to export the build libs and headers.@Vertexwahn slack directed me to raise this issue in the repo and to ask you if this would be the right course to take?
With the hard work already done seems possible to refactor
BUILD.bazel
to add this rule but I'd first like some confirmation this is the right path.The text was updated successfully, but these errors were encountered: