Fix incorrect string operations on bytes output of 'ps' subprocess #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parikshit Tiwari <[email protected]>
JeanChristopheMorinPerso
requested changes
Jun 22, 2024
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1765 +/- ##
==========================================
- Coverage 58.41% 57.93% -0.48%
==========================================
Files 126 126
Lines 17163 17134 -29
Branches 3506 3519 +13
==========================================
- Hits 10025 9926 -99
- Misses 6473 6533 +60
- Partials 665 675 +10 ☔ View full report in Codecov by Sentry. |
JeanChristopheMorinPerso
approved these changes
Jun 29, 2024
JeanChristopheMorinPerso
merged commit 57136a3
into
AcademySoftwareFoundation:main
47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subprocess to get the current shell name would always return a bytes output. The subsequent string operations on
that output would always fail with a TypeError.
Using subprocess.run() along with its text flag will fix the issue at hand as well as bring the code in-line with python's.recommendation of using run for all use cases it can handle. The current use case does not warrant a use for subprocess.communicate()
Closes #1754