Merge pull request #2063 from Accenture/bug/2061-print-error-if-mcdev-validationsjs-could-not-be-loaded-due-to-a-syntax-error

Bug/2061 print error if mcdev validationsjs could not be loaded due to a syntax error

Author: JoernBerkefeld

lib/Builder.js

@@ -330,7 +330,12 @@ saved
         // Clear output folder structure for selected sub-type
         // only run this if the standard deploy folder is a target of buildDefinition (which technically could be changed)
         Util.logger.info(` - 🚮 purging folder ${deployDir}`);
-        await File.remove(deployDir);
+        try {
+            await File.remove(deployDir);
+        } catch {
+            // sometimes the first attempt is not successful for some operating system reason. Trying again mostly solves this
+            await File.remove(deployDir);
+        }
     }
 }
 

lib/util/validations.js

@@ -13,8 +13,17 @@ let customRules = {};
 let customRuleImport;
 try {
     customRuleImport = await import('file://' + path.join(process.cwd(), '.mcdev-validations.js'));
-} catch {
-    Util.logger.debug('.mcdev-validations.js not found');
+} catch (ex) {
+    if (ex instanceof SyntaxError) {
+        Util.logger.error('SyntaxError in .mcdev-validations.js: ' + ex.message);
+    } else if (ex.code === 'ERR_MODULE_NOT_FOUND') {
+        Util.logger.debug('.mcdev-validations.js not found');
+    } else {
+        Util.logger.errorStack(
+            ex,
+            'Could not load custom validation rules from .mcdev-validations.js'
+        );
+    }
 }
 /**
  *