fix: Don't enable the zbus/tokio feature on Unix
#521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lunixbochs Can you easily test this solution and make sure it does what you need? Thanks. |
|
Given that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #515
For simplicity, I chose to also drop the path to spawn a task using the unstable API. We'd have to enable the
tokio_unstableflag ourself (previously done by zbus), just to name the task. Yes this would be useful in diagnozing a crash, but we don't test this enough for me to feel confident keeping this unstable code around.Tested by running the winit example with both runtimes.