Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo: Extract to Config File #47

Open
no-reply opened this issue Feb 11, 2017 · 1 comment
Open

ToDo: Extract to Config File #47

no-reply opened this issue Feb 11, 2017 · 1 comment

Comments

@no-reply
Copy link
Member

no-reply commented Feb 11, 2017

There is a @todo item in settings that seems to date to the earliest commits: https://github.com/ActiveTriples/linked-data-fragments/blob/f6d2e49540bde4ee926bd34ccd9f8c175f774935/lib/linked_data_fragments/settings.rb

It suggests we should remove settings to a config file. The settings module essentially functions as an interface over the config. Is this @todo item still needed? Is there more to do here?

@elrayle
Copy link
Member

elrayle commented Feb 21, 2017

We should consider the configuration process in branch cache_config when evaluating whether and how to move the settings to a config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants