diff --git a/app/__init__.py b/app/__init__.py index 3c581ceeb..548627e4b 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -2,6 +2,8 @@ from .db import db, migrate from .models import task, goal import os +from .routes.task_routes import tasks_bp +from .routes.goal_routes import goals_bp def create_app(config=None): app = Flask(__name__) @@ -18,5 +20,7 @@ def create_app(config=None): migrate.init_app(app, db) # Register Blueprints here + app.register_blueprint(tasks_bp) + app.register_blueprint(goals_bp) return app diff --git a/app/models/goal.py b/app/models/goal.py index 44282656b..12b1d0c4c 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -1,5 +1,27 @@ -from sqlalchemy.orm import Mapped, mapped_column +from sqlalchemy.orm import Mapped, mapped_column, relationship +from .task import Task from ..db import db +from typing import List class Goal(db.Model): id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) + title: Mapped[str] + tasks: Mapped[List["Task"]] = relationship("Task", back_populates="goal") + + def to_dict(self): + goal_as_dict = { + "id": self.id, + "title": self.title, + "tasks": [task.to_dict() for task in self.tasks] # Include tasks in the goal's dict + } + return goal_as_dict + + @classmethod + def from_dict(cls, goal_data): + return cls(title=goal_data["title"]) + + def add_tasks(self, task_ids: List[int]): + tasks = Task.query.filter(Task.id.in_(task_ids)).all() + for task in tasks: + task.goal_id = self.id # Assign each task's goal_id + db.session.commit() \ No newline at end of file diff --git a/app/models/task.py b/app/models/task.py index 5d99666a4..f988433c2 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,29 @@ -from sqlalchemy.orm import Mapped, mapped_column +from sqlalchemy.orm import Mapped, mapped_column, relationship from ..db import db +from datetime import datetime +from typing import Optional +from sqlalchemy import ForeignKey class Task(db.Model): id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) + title: Mapped[str] + description: Mapped[str] + completed_at: Mapped[Optional[datetime]] = mapped_column(nullable=True) + goal_id: Mapped[Optional[int]] = mapped_column(ForeignKey("goal.id"), nullable=True) + goal: Mapped[Optional["Goal"]] = relationship(back_populates="tasks") + + def to_dict(self): + return { + "id": self.id, + "title": self.title, + "description": self.description, + "is_complete": bool(self.completed_at) + } + + @classmethod + def from_dict(cls, task_data): + return cls( + title=task_data["title"], + description=task_data["description"], + completed_at=task_data.get("completed_at") + ) \ No newline at end of file diff --git a/app/routes/goal_routes.py b/app/routes/goal_routes.py index 3aae38d49..a08418cb7 100644 --- a/app/routes/goal_routes.py +++ b/app/routes/goal_routes.py @@ -1 +1,119 @@ -from flask import Blueprint \ No newline at end of file +from flask import Blueprint, abort, make_response, request, Response +from app.models.goal import Goal +from ..db import db +from datetime import datetime, timezone + +goals_bp = Blueprint("goals_bp", __name__, url_prefix="/goals") + +##refactor validate!! +@goals_bp.post("//tasks") +def create_goal_with_task(goal_id): + goal = validate_model(Goal, goal_id) + + request_body = request.get_json() + request_body["goal_id"] = goal.id + + try: + new_task = Task.from_dict(request_body) + except KeyError as error: + response = {"message": f"Invalid requests: missing {error.ergs[0]}"} + abort(make_response(response, 400)) + db.session.add(new_task) + db.session.commit() + + return make_response(new_task.to_dict(), 201) + +@goals_bp.post("") +def create_goal(): + request_body = request.get_json() + + # Validate request data + if "title" not in request_body: + response = {"details": "Invalid data"} + return make_response(response, 400) + + title = request_body["title"] + + # Create new goal instance + new_goal = Goal(title=title) + + # Add new goal to the database session and commit + db.session.add(new_goal) + db.session.commit() + + response = { + "goal": { + "id": new_goal.id, + "title": new_goal.title, + } + } + + return response, 201 + +@goals_bp.get('/') +def get_one_goal(goal_id): + goal = validate_goal(goal_id) + + return { + "goal":{ + "id": goal.id, + "title": goal.title, + } + } + + +@goals_bp.get("") +def get_all_goals(): + query = db.select(Goal).order_by(Goal.id) + goals = db.session.scalars(query) + + goals_response = [] + for goal in goals: + goals_response.append( + { + "id": goal.id, + "title": goal.title, + } + ) + return goals_response + +@goals_bp.put("/") +def update_goal(goal_id): + goal = validate_goal(goal_id) + request_body = request.get_json() + + goal.title = request_body["title"] + + db.session.commit() + + return { + "goal": { + "id": goal.id, + "title": goal.title, + } + }, 200 + +@goals_bp.delete("") +def delete_task(goal_id): + goal = validate_goal(goal_id) + db.session.delete(goal) + db.session.commit() + + return {"details":f'Goal {goal_id} "{goal.title}" successfully deleted'},200 + # Response(status=204, mimetype="application/json") + +def validate_goal(goal_id): + try: + goal_id = int(goal_id) + except ValueError: + response = {"message": f"goal {goal_id} invalid"} + abort(make_response(response,400)) + + query = db.select(Goal).where(Goal.id == goal_id) + goal = db.session.scalar(query) + + if not goal: + response = {"message": f"goal {goal_id} not found"} + abort(make_response(response, 404)) + + return goal \ No newline at end of file diff --git a/app/routes/route_utilities.py b/app/routes/route_utilities.py new file mode 100644 index 000000000..38c45ddc5 --- /dev/null +++ b/app/routes/route_utilities.py @@ -0,0 +1,19 @@ +from flask import abort, make_response +from ..db import db + +def validate_model(cls, model_id): + try: + model_id = int(model_id) + except: + response = {"message": f"{cls.__name__} {model_id} invalid"} + abort(make_response(response , 400)) + + query = db.select(cls).where(cls.id == model_id) + model = db.session.scalar(query) + + if not model: + response = {"message": f"{cls.__name__} {model_id} not found"} + abort(make_response(response, 404)) + + return model + diff --git a/app/routes/task_routes.py b/app/routes/task_routes.py index 3aae38d49..827aff66b 100644 --- a/app/routes/task_routes.py +++ b/app/routes/task_routes.py @@ -1 +1,173 @@ -from flask import Blueprint \ No newline at end of file +from flask import Blueprint, abort, make_response, request, Response +from app.models.task import Task +from ..db import db +from datetime import datetime, timezone + +tasks_bp = Blueprint("tasks_bp", __name__, url_prefix="/tasks") + + +@tasks_bp.post("") +def create_task(): + request_body = request.get_json() + + #validate request data + if "title" not in request_body or "description" not in request_body: + response = {"details": "Invalid data"} + return make_response(response,400) + + title = request_body["title"] + description = request_body["description"] + completed_at = request_body.get("completed_at") + + new_task = Task(title=title, description=description, completed_at=completed_at) + db.session.add(new_task) + db.session.commit() + + response = { + "task":{ + "id": new_task.id, + "title": new_task.title, + "description": new_task.description, + "is_complete": bool(new_task.completed_at) + } + } + return response, 201 + +@tasks_bp.get('/') +def get_one_task(task_id): + task = validate_task(task_id) + + return { + "task":{ + "id": task.id, + "title": task.title, + "description": task.description, + "is_complete": bool(task.completed_at) + } + } + +@tasks_bp.get("") +def get_all_tasks(): + + sort_param = request.args.get("sort", "").lower() + + if sort_param and sort_param.lower() == "asc": + query = db.select(Task).order_by(Task.title) + + elif sort_param and sort_param.lower() == "desc": + query = db.select(Task).order_by(Task.title.desc()) + else: + query = db.select(Task).order_by(Task.title) + + tasks = db.session.scalars(query) + + + tasks_response = [] + for task in tasks: + tasks_response.append( + { + "id": task.id, + "title": task.title, + "description": task.description, + "is_complete": bool(task.completed_at) + } + ) + return tasks_response + +@tasks_bp.put("/") +def update_task(task_id): + task = validate_task(task_id) + request_body = request.get_json() + + # Validate request data + if "title" not in request_body or "description" not in request_body: + return make_response({"details": "Invalid data"}, 400) + + task.title = request_body["title"] + task.description = request_body["description"] + + # Keep completed_at unchanged if not provided + if "completed_at" in request_body: + task.completed_at = request_body["completed_at"] + + db.session.commit() + + return { + "task": { + "id": task.id, + "title": task.title, + "description": task.description, + "is_complete": bool(task.completed_at) # Convert completed_at to boolean + } + }, 200 + +@tasks_bp.delete("") +def delete_task(task_id): + task = validate_task(task_id) + db.session.delete(task) + db.session.commit() + + return {"details":f'Task {task_id} "{task.title}" successfully deleted'},200 + # Response(status=204, mimetype="application/json") + +def validate_task(task_id): + try: + task_id = int(task_id) + except ValueError: + response = {"message": f"task {task_id} invalid"} + abort(make_response(response,400)) + + query = db.select(Task).where(Task.id == task_id) + task = db.session.scalar(query) + + if not task: + response = {"message": f"task {task_id} not found"} + abort(make_response(response, 404)) + + return task + +@tasks_bp.patch("//mark_complete") +def mark_complete(task_id): + task = validate_task(task_id) + + # Update completed_at to mark the task as completed + task.completed_at = datetime.now(timezone.utc) + + # Commit the changes to the database + db.session.commit() + + # Prepare the response + response = { + "task": { + "id": task.id, + "title": task.title, + "description": task.description, + "is_complete": bool(task.completed_at) + } + } + return response, 200 + +@tasks_bp.patch("//mark_incomplete") +def mark_incomplete(task_id): + task = validate_task(task_id) + + # Update completed_at to mark the task as completed + task.completed_at = None + + # Commit the changes to the database + db.session.commit() + + # Prepare the response + response = { + "task": { + "id": task.id, + "title": task.title, + "description": task.description, + "is_complete": bool(task.completed_at) + } + } + return response, 200 + + + + diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..0e0484415 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Single-database configuration for Flask. diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..ec9d45c26 --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,50 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic,flask_migrate + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[logger_flask_migrate] +level = INFO +handlers = +qualname = flask_migrate + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..4c9709271 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,113 @@ +import logging +from logging.config import fileConfig + +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + + +def get_engine(): + try: + # this works with Flask-SQLAlchemy<3 and Alchemical + return current_app.extensions['migrate'].db.get_engine() + except (TypeError, AttributeError): + # this works with Flask-SQLAlchemy>=3 + return current_app.extensions['migrate'].db.engine + + +def get_engine_url(): + try: + return get_engine().url.render_as_string(hide_password=False).replace( + '%', '%%') + except AttributeError: + return str(get_engine().url).replace('%', '%%') + + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option('sqlalchemy.url', get_engine_url()) +target_db = current_app.extensions['migrate'].db + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def get_metadata(): + if hasattr(target_db, 'metadatas'): + return target_db.metadatas[None] + return target_db.metadata + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=get_metadata(), literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + conf_args = current_app.extensions['migrate'].configure_args + if conf_args.get("process_revision_directives") is None: + conf_args["process_revision_directives"] = process_revision_directives + + connectable = get_engine() + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=get_metadata(), + **conf_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/28fe8bb46b24_.py b/migrations/versions/28fe8bb46b24_.py new file mode 100644 index 000000000..d718b92cd --- /dev/null +++ b/migrations/versions/28fe8bb46b24_.py @@ -0,0 +1,34 @@ +"""empty message + +Revision ID: 28fe8bb46b24 +Revises: 7932e5760d00 +Create Date: 2024-11-02 22:58:12.829735 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '28fe8bb46b24' +down_revision = '7932e5760d00' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('task', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.Column('description', sa.String(), nullable=False), + sa.Column('completed_at', sa.String(), nullable=True), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + # ### end Alembic commands ### diff --git a/migrations/versions/417c51f1c2a6_.py b/migrations/versions/417c51f1c2a6_.py new file mode 100644 index 000000000..7a2a5d794 --- /dev/null +++ b/migrations/versions/417c51f1c2a6_.py @@ -0,0 +1,39 @@ +"""empty message + +Revision ID: 417c51f1c2a6 +Revises: +Create Date: 2024-11-02 14:16:26.697264 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '417c51f1c2a6' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.PrimaryKeyConstraint('id') + ) + op.create_table('task', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.Column('description', sa.String(), nullable=False), + sa.Column('completed_at', sa.String(), nullable=True), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/migrations/versions/72107c219903_add_goal_py_model.py b/migrations/versions/72107c219903_add_goal_py_model.py new file mode 100644 index 000000000..71f52d369 --- /dev/null +++ b/migrations/versions/72107c219903_add_goal_py_model.py @@ -0,0 +1,32 @@ +"""add goal.py model + +Revision ID: 72107c219903 +Revises: 28fe8bb46b24 +Create Date: 2024-11-07 15:02:49.286144 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '72107c219903' +down_revision = '28fe8bb46b24' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('goal', schema=None) as batch_op: + batch_op.add_column(sa.Column('title', sa.String(), nullable=False)) + + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + with op.batch_alter_table('goal', schema=None) as batch_op: + batch_op.drop_column('title') + + # ### end Alembic commands ### diff --git a/migrations/versions/7932e5760d00_recreate_tasks_table.py b/migrations/versions/7932e5760d00_recreate_tasks_table.py new file mode 100644 index 000000000..58501ed01 --- /dev/null +++ b/migrations/versions/7932e5760d00_recreate_tasks_table.py @@ -0,0 +1,34 @@ +"""recreate tasks table + +Revision ID: 7932e5760d00 +Revises: 417c51f1c2a6 +Create Date: 2024-11-02 17:07:47.570831 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '7932e5760d00' +down_revision = '417c51f1c2a6' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('task', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=False), + sa.Column('description', sa.String(), nullable=False), + sa.Column('completed_at', sa.String(), nullable=True), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + # ### end Alembic commands ### diff --git a/tests/conftest.py b/tests/conftest.py index e370e597b..28c3dc981 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -92,11 +92,6 @@ def one_goal(app): db.session.commit() -# This fixture gets called in every test that -# references "one_task_belongs_to_one_goal" -# This fixture creates a task and a goal -# It associates the goal and task, so that the -# goal has this task, and the task belongs to one goal @pytest.fixture def one_task_belongs_to_one_goal(app, one_goal, one_task): task = Task.query.first() diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..796367e1b 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,7 +51,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -59,14 +59,10 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 + assert "message" in response_body + - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - - -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -93,7 +89,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -119,7 +115,7 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -130,14 +126,11 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 + assert response_body == {"message": "task 1 not found"} + - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +145,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -161,15 +154,12 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - + + assert response_body == {"message": "task 1 not found"} assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +176,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..c9a76e6b1 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 32d379822..1eff95ab9 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -42,7 +42,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -62,7 +62,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -99,7 +99,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +119,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -127,14 +127,9 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == {"message": "task 1 not found"} - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - - -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -142,8 +137,4 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 - - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** + assert response_body == {"message": "task 1 not found"} diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..13976e999 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,8 @@ +from app.models.goal import Goal import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +13,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +30,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +47,19 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): pass # Act response = client.get("/goals/1") response_body = response.get_json() - - raise Exception("Complete test") # Assert - # ---- Complete Test ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Test ---- + assert response.status_code == 404 + assert response_body == {"message": "goal 1 not found"} + -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +78,41 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +#@pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + }) - # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here - # ---- Complete Assertions Here ---- + response_body = response.get_json() + # Assert + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title", + } + } -@pytest.mark.skip(reason="test to be completed by student") +#@pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") # Act - # ---- Complete Act Here ---- + response = client.put("/tasks/1", json={ + "title": "Updated Task Title", + "description": "Updated Test Description", + }) + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + assert response_body == {"message": "task 1 not found"} + -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -124,27 +129,22 @@ def test_delete_goal(client, one_goal): response = client.get("/goals/1") assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - + assert Goal.query.get(1) == None -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") - # Act - # ---- Complete Act Here ---- + response = client.delete("/tasks/1") + response_body = response.get_json() # Assert - # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # ---- Complete Assertions Here ---- + assert response.status_code == 404 + + assert response_body == {"message": "task 1 not found"} + assert Goal.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +#@pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={})