Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py not installing langkit.lexer #149

Closed
briot opened this issue Mar 21, 2019 · 2 comments
Closed

setup.py not installing langkit.lexer #149

briot opened this issue Mar 21, 2019 · 2 comments

Comments

@briot
Copy link
Contributor

briot commented Mar 21, 2019

It seems to me that packages in setup.py should also include langkit.lexer.
Otherwise, the directory langkit/lexer is not copied when installing, and the compilation
of libadalang fails down the road...

Thanks !

@pmderodat
Copy link
Member

Hello,

Thanks for reporting this, we’ll fix it. Note that we’ll soon have a Travis CI setup for Langkit, so as suggested a long time ago in #9, we should have automated way of detecting these issues soon. :-)

pmderodat added a commit to pmderodat/langkit that referenced this issue Mar 27, 2019
Roldak pushed a commit that referenced this issue Mar 29, 2019
TN: S315-028
For GitHub issue #149
@pmderodat
Copy link
Member

Hello @briot

This is now fixed, and our Travis CI setup now uses setup.py, so we should be able to detect future occurences of this issue before they get to the master branch. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants