Missing Value of SLOC

[pjljvandelaar]

Dear adaCore,

I am missing some basic functionality.
The Value function (the inverse of image )
is not present.

A simple solution might be to add functions like

   function Source_Location_Value (Source_Location_String : String) return Source_Location
   is
      Index_Colon : constant Natural := Index (Source_Location_String, ":");
      Line : constant Line_Number := 
        Line_Number'Value (Head (Source_Location_String, Index_Colon - Source_Location_String'First));
      Column : constant Column_Number := 
        Column_Number'Value (Tail (Source_Location_String, Source_Location_String'Last - Index_Colon));
   begin
      return (Line => Line,
              Column => Column);
   end Source_Location_Value;

   function Source_Location_Range_Value (Source_Location_Range_String : String) 
                                         return Source_Location_Range
   is
      Index_Dash : constant Natural := Index (Source_Location_Range_String, "-");
      Start_Location_String : constant String := 
        Head (Source_Location_Range_String, Index_Dash - Source_Location_Range_String'First);
      Start_Location : constant Source_Location := Source_Location_Value (Start_Location_String);
      End_Location_String : constant String := 
        Tail (Source_Location_Range_String, Source_Location_Range_String'Last - Index_Dash);
      End_Location : constant Source_Location := Source_Location_Value (End_Location_String);
   begin
      return (Start_Line   => Start_Location.Line,
              End_Line     => End_Location.Line,
              Start_Column => Start_Location.Column, 
              End_Column   => End_Location.Column);
   end Source_Location_Range_Value;

[pmderodat]

Hello,

This is now implemented (two new Value functions in Langkit_Support.Slocs, thank you for the suggestion!

[pjljvandelaar]

Thanks!

I reported a minor issue on the commit.

[pjljvandelaar]

Found a typo: Roldak@5adc777#r50932637

[pmderodat]

Typo fix is now merged, thanks!