Update answers so no warnings

frank-at-adacore · frank-at-adacore · commit ef66245c2318 · 2025-08-23T13:00:43.000-04:00
diff --git a/courses/ada_essentials/070_subprograms/lab/subprograms/ada95/main.adb b/courses/ada_essentials/070_subprograms/lab/subprograms/ada95/main.adb
@@ -26,7 +26,7 @@ procedure Main is
    Length : Natural := 0;
 
    procedure Add (Item : Integer) is
-      Place : Natural := Search (List (1..Length), Item);
+      Place : constant Natural := Search (List (1..Length), Item);
    begin
       if List (Place) /= Item then
          Length                     := Length + 1;
diff --git a/courses/ada_essentials/070_subprograms/lab/subprograms/answer/main.adb b/courses/ada_essentials/070_subprograms/lab/subprograms/answer/main.adb
@@ -29,7 +29,7 @@ procedure Main is
 
 --Main
    procedure Add (Item : Integer) is
-      Place : Natural := Search (List (1..Length), Item);
+      Place : constant Natural := Search (List (1..Length), Item);
    begin
       if List (Place) /= Item then
          Length                     := Length + 1;
diff --git a/courses/ada_essentials/135_visibility/lab/visibility/answer/default.gpr b/courses/ada_essentials/135_visibility/lab/visibility/answer/default.gpr
@@ -1,5 +1,5 @@
 project Default is
-   for Main use ("main.adb");
+   for Main use ("main1.adb", "main2.adb");
    for Source_Dirs use (".");
    package Compiler is
      for Switches ("ada") use ("-g","-gnata","-gnatyr","-gnatwa");
diff --git a/courses/ada_essentials/135_visibility/lab/visibility/answer/main1.adb b/courses/ada_essentials/135_visibility/lab/visibility/answer/main1.adb
@@ -4,13 +4,13 @@ with Triangles;
 procedure Main1 is
 
    use type Quads.Side_T;
-   Q_Sides : Natural renames Quads.Number_Of_Sides;
-   Quad    : Quads.Shape_T := (1, 2, 3, 4);
+   Q_Sides    : Natural renames Quads.Number_Of_Sides;
+   Quad       : constant Quads.Shape_T := (1, 2, 3, 4);
    Quad_Total : Quads.Side_T := 0;
 
    use type Triangles.Side_T;
-   T_Sides  : Natural renames Triangles.Number_Of_Sides;
-   Triangle : Triangles.Shape_T := (1, 2, 3);
+   T_Sides        : Natural renames Triangles.Number_Of_Sides;
+   Triangle       : constant Triangles.Shape_T := (1, 2, 3);
    Triangle_Total : Triangles.Side_T := 0;
 
 begin
diff --git a/courses/ada_essentials/135_visibility/lab/visibility/answer/main2.adb b/courses/ada_essentials/135_visibility/lab/visibility/answer/main2.adb
@@ -4,12 +4,12 @@ with Triangles;   use Triangles;
 procedure Main2 is
    function Q_Image (S : Quads.Side_T) return String
       renames Quads.Side_T'Image;
-   Quad : Quads.Shape_T := (1, 2, 3, 4);
+   Quad       : constant Quads.Shape_T := (1, 2, 3, 4);
    Quad_Total : Quads.Side_T := 0;
 
    function T_Image (S : Triangles.Side_T) return String
       renames Triangles.Side_T'Image;
-   Triangle : Triangles.Shape_T := (1, 2, 3);
+   Triangle       : constant Triangles.Shape_T := (1, 2, 3);
    Triangle_Total : Triangles.Side_T := 0;
 
 begin
diff --git a/courses/ada_essentials/135_visibility/lab/visibility/prompt/default.gpr b/courses/ada_essentials/135_visibility/lab/visibility/prompt/default.gpr
@@ -1,5 +1,5 @@
 project Default is
-   for Main use ("main.adb");
+   for Main use ("main1.adb", "main2.adb");
    for Source_Dirs use (".");
    package Compiler is
      for Switches ("ada") use ("-g","-gnata","-gnatyr");
diff --git a/courses/ada_essentials/140_access_types/lab/access_types-in_depth/answer/database_list.adb b/courses/ada_essentials/140_access_types/lab/access_types-in_depth/answer/database_list.adb
@@ -1,8 +1,6 @@
 --Database_List_Helpers
-with Interfaces;
-with Unchecked_Deallocation;
+with Ada.Unchecked_Deallocation;
 package body Database_List is
-   use type Database.Database_T;
 
    function Is_Empty (List : List_T) return Boolean is
    begin
@@ -37,7 +35,7 @@ package body Database_List is
 --Database_List_Substance
    procedure Insert (List      : in out List_T;
                      Component :        Database_T) is
-      New_Component : Linked_List_Ptr_T :=
+      New_Component : constant Linked_List_Ptr_T :=
         new Linked_List_T'(Next => null, Content => Component);
    begin
       if Is_Empty (List) then
@@ -63,7 +61,7 @@ package body Database_List is
       -- Memory_Mgmt.Print_Info;
    end Insert;
 
-   procedure Free is new Unchecked_Deallocation
+   procedure Free is new Ada.Unchecked_Deallocation
      (Linked_List_T, Linked_List_Ptr_T);
    procedure Delete
      (List      : in out List_T;
@@ -77,7 +75,7 @@ package body Database_List is
             List.Current := List.Head;
          else
             declare
-               Previous : Linked_List_Ptr_T := List.Head;
+               Previous : constant Linked_List_Ptr_T := List.Head;
                Current  : Linked_List_Ptr_T := List.Head.Next;
             begin
                while Current /= null loop
diff --git a/courses/ada_essentials/140_access_types/lab/access_types/ada95/main.adb b/courses/ada_essentials/140_access_types/lab/access_types/ada95/main.adb
@@ -1,3 +1,4 @@
+pragma Warnings (Off, "anonymous access type");
 with Ada.Text_IO;      use Ada.Text_IO;
 with Password_Manager; use Password_Manager;
 procedure Main is
@@ -25,3 +26,4 @@ begin
    end loop;
 
 end Main;
+pragma Warnings (On, "anonymous access type");
diff --git a/courses/ada_essentials/140_access_types/lab/access_types/answer/main.adb b/courses/ada_essentials/140_access_types/lab/access_types/answer/main.adb
@@ -1,3 +1,4 @@
+pragma Warnings (Off, "anonymous access type");
 with Ada.Text_IO;      use Ada.Text_IO;
 with Password_Manager; use Password_Manager;
 procedure Main is
@@ -22,3 +23,4 @@ begin
          View (Login).Count'Image);
    end loop;
 end Main;
+pragma Warnings (On, "anonymous access type");
diff --git a/courses/ada_essentials/160_genericity/lab/genericity/ada95/main.adb b/courses/ada_essentials/160_genericity/lab/genericity/ada95/main.adb
@@ -7,7 +7,6 @@ procedure Main is
                                      Image     => Data_Type.Image);
 
    My_List : List.List_T;
-   Component : Data_Type.Record_T;
 
 begin
    List.Add (My_List, (Integer_Component   => 111,
diff --git a/courses/ada_essentials/160_genericity/lab/genericity/answer/generic_list.adb b/courses/ada_essentials/160_genericity/lab/genericity/answer/generic_list.adb
@@ -1,4 +1,4 @@
-with Ada.Text_io; use Ada.Text_IO;
+with Ada.Text_IO; use Ada.Text_IO;
 package body Generic_List is
 
    procedure Add (This : in out List_T;
diff --git a/courses/ada_essentials/160_genericity/lab/genericity/answer/main.adb b/courses/ada_essentials/160_genericity/lab/genericity/answer/main.adb
@@ -7,7 +7,6 @@ procedure Main is
                                      Image => Data_Type.Image);
 
    My_List : List.List_T;
-   Component : Data_Type.Record_T;
 
 begin
    List.Add (My_List, (Integer_Component   => 111,
diff --git a/courses/ada_essentials/170_tagged_derivation/lab/tagged_derivation/ada95/main.adb b/courses/ada_essentials/170_tagged_derivation/lab/tagged_derivation/ada95/main.adb
@@ -1,4 +1,3 @@
-with Ada.Text_IO; use Ada.Text_IO;
 with Employee;
 procedure Main is
    Applicant : Employee.Person_T;
diff --git a/courses/ada_essentials/170_tagged_derivation/lab/tagged_derivation/answer/main.adb b/courses/ada_essentials/170_tagged_derivation/lab/tagged_derivation/answer/main.adb
@@ -1,4 +1,3 @@
-with Ada.Text_IO; use Ada.Text_IO;
 with Employee;
 procedure Main is
    Applicant : Employee.Person_T;
diff --git a/courses/ada_essentials/190_exceptions/lab/exceptions-in_depth/answer/main.adb b/courses/ada_essentials/190_exceptions/lab/exceptions-in_depth/answer/main.adb
@@ -39,7 +39,7 @@ begin
       begin
          exit when Input'Length = 0;
          Parser (Input, Left, Operator, Right);
-         case Component (Operator, 1) is
+         case Element (Operator, 1) is
             when '+' =>
                Put_Line
                  ("  => " &
diff --git a/courses/ada_essentials/230_interfacing_with_c/lab/interfacing_with_c/ada95/main.adb b/courses/ada_essentials/230_interfacing_with_c/lab/interfacing_with_c/ada95/main.adb
@@ -20,15 +20,15 @@ procedure Main is
    function C_Miles_Per_Hour (Data : Data_T) return Interfaces.C.C_float;
    pragma Import (C, C_Miles_Per_Hour, "miles_per_hour");
 
-   Object_Feet : Data_T :=
+   Object_Feet : constant Data_T :=
      (Distance => 6_000.0,
       Distance_Type => Feet,
       Seconds  => One_Minute_In_Seconds);
-   Object_Meters : Data_T :=
+   Object_Meters : constant Data_T :=
      (Distance => 3_000.0,
       Distance_Type => Meters,
       Seconds  => One_Hour_In_Seconds);
-   Object_Miles : Data_T :=
+   Object_Miles : constant Data_T :=
      (Distance => 1.0,
       Distance_Type =>
       Miles, Seconds => 1.0);
diff --git a/courses/ada_essentials/280_low_level_programming/lab/low_level_programming/ada95/main.adb b/courses/ada_essentials/280_low_level_programming/lab/low_level_programming/ada95/main.adb
@@ -59,7 +59,7 @@ procedure Main is
    begin
       Messages.Read (Message, Valid);
       Ada.Text_IO.Put_Line("Message valid: " & Boolean'Image (Valid));
-   end read;
+   end Read;
 begin
    loop
       Put ("Create Write Read Print: ");
@@ -73,7 +73,7 @@ begin
             when 'w' | 'W' =>
                Messages.Write (Message);
             when 'r' | 'R' =>
-               read;
+               Read;
             when 'p' | 'P' =>
                Messages.Print (Message);
             when others =>
diff --git a/courses/ada_essentials/280_low_level_programming/lab/low_level_programming/ada95/messages.adb b/courses/ada_essentials/280_low_level_programming/lab/low_level_programming/ada95/messages.adb
@@ -1,5 +1,5 @@
 with Ada.Text_IO;
-with Unchecked_Conversion;
+with Ada.Unchecked_Conversion;
 package body Messages is
    Global_Unique_Id : U32_T := 0;
    function To_Text (Str : String) return Text_T is
@@ -45,8 +45,8 @@ package body Messages is
    type Char is new Character;
    for Char'Size use 8;
    type Overlay_T is array (1 .. Message_T'Size / 8) of Char;
-   function Convert is new Unchecked_Conversion (Message_T, Overlay_T);
-   function Convert is new Unchecked_Conversion (Overlay_T, Message_T);
+   function Convert is new Ada.Unchecked_Conversion (Message_T, Overlay_T);
+   function Convert is new Ada.Unchecked_Conversion (Overlay_T, Message_T);
    Const_Filename : constant String := "message.txt";
    procedure Write (Message : Message_T) is
       Overlay : constant Overlay_T := Convert (Message);
diff --git a/courses/ada_essentials/280_low_level_programming/lab/low_level_programming/ada95/messages.ads b/courses/ada_essentials/280_low_level_programming/lab/low_level_programming/ada95/messages.ads
@@ -12,7 +12,7 @@ package Messages is
    function Get_Crc (Message : Message_T) return Crc_T;
    procedure Write (Message : Message_T);
    procedure Read (Message : out Message_T;
-                    valid : out boolean);
+                   Valid : out boolean);
    procedure Print (Message : Message_T);
 private
    type U32_T is mod 2**32;
diff --git a/courses/ada_essentials/280_low_level_programming/lab/low_level_programming/answer/main.adb b/courses/ada_essentials/280_low_level_programming/lab/low_level_programming/answer/main.adb
@@ -54,7 +54,7 @@ procedure Main is
    begin
       Messages.Read (Message, Valid);
       Ada.Text_IO.Put_Line("Message valid: " & Boolean'Image (Valid));
-   end read;
+   end Read;
 begin
    loop
       Put ("Create Write Read Print: ");
@@ -68,7 +68,7 @@ begin
             when 'w' | 'W' =>
                Messages.Write (Message);
             when 'r' | 'R' =>
-               read;
+               Read;
             when 'p' | 'P' =>
                Messages.Print (Message);
             when others =>
diff --git a/courses/ada_essentials/280_low_level_programming/lab/low_level_programming/answer/messages.ads b/courses/ada_essentials/280_low_level_programming/lab/low_level_programming/answer/messages.ads
@@ -12,7 +12,7 @@ package Messages is
    function Get_Crc (Message : Message_T) return Crc_T;
    procedure Write (Message : Message_T);
    procedure Read (Message : out Message_T;
-                    valid : out boolean);
+                   Valid : out boolean);
    procedure Print (Message : Message_T);
 private
    type U32_T is mod 2**32;
diff --git a/courses/ada_essentials/290_advanced_data_hiding/lab/advanced_data_hiding/ada95/messages-list_types-operations.ads b/courses/ada_essentials/290_advanced_data_hiding/lab/advanced_data_hiding/ada95/messages-list_types-operations.ads
@@ -1,4 +1,3 @@
-with Messages.List_Types;
 package Messages.List_Types.Operations is
    procedure Append (List : in out List_T;
                      Item :        Message_T);
diff --git a/courses/ada_essentials/290_advanced_data_hiding/lab/advanced_data_hiding/answer/messages-list_types-operations.ads b/courses/ada_essentials/290_advanced_data_hiding/lab/advanced_data_hiding/answer/messages-list_types-operations.ads
@@ -1,4 +1,3 @@
-with Messages.List_Types;
 package Messages.List_Types.Operations is
    procedure Append (List : in out List_T;
                      Item :        Message_T);
diff --git a/courses/ada_essentials/893_ada_numerics/lab/ada_numerics/answer/main.adb b/courses/ada_essentials/893_ada_numerics/lab/ada_numerics/answer/main.adb
@@ -21,11 +21,11 @@ procedure Main is
    F_Generator : F_Random.Generator;
 
    function Random_Float return Float is
-      R     : Float    := F_Random.Random (F_Generator);
+      Rand  : constant Float := F_Random.Random (F_Generator);
       First : constant := 1_000.0;
       Last  : constant := 9_999.0;
    begin
-      return R * (Last - First) + First;
+      return Rand * (Last - First) + First;
    end Random_Float;
 
 begin
