Skip to content

Latest commit

 

History

History
62 lines (44 loc) · 3.02 KB

feedback.md

File metadata and controls

62 lines (44 loc) · 3.02 KB

Grocery Store

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
The Customer and Order classes have appropriate attr_ helpers for instance variables ✔️
The CSV library is used in .all methods, and not in .find methods ✔️
Appropriately parses the product data from CSV file in Order.all ✔️
Order.all calls Customer.find to set up the composition relation ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️

Functional Requirements

Functional Requirement yes/no
All of the wave 1 tests in Customer pass ✔️
All of the wave 1 tests in Order pass ✔️
All of the wave 2 tests in Customer pass ✔️
All of the wave 2 tests in Order pass ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 2+ in Code Review && 2+ in Functional Requirements ✔️
Red (Not at Standard) 0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging ✔️

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized