Skip to content

Conversation

@C-Achard
Copy link
Collaborator

@C-Achard C-Achard commented Apr 2, 2024

Fixes warning when building from setuptools :

    ********************************************************************************
    Usage of dash-separated 'napari-cellseg3d' will not be supported in future
    versions. Please use the underscore name 'napari_cellseg3d' instead.
    By 2024-Sep-26, you need to update your project and remove deprecated calls
    or your builds will no longer be supported.
    See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
    ********************************************************************************

@C-Achard C-Achard added the fix Something needs to be or has been fixed label Apr 2, 2024
@C-Achard C-Achard self-assigned this Apr 2, 2024
@C-Achard
Copy link
Collaborator Author

C-Achard commented May 3, 2024

@MMathisLab Just to confirm, this will not affect the project name on PyPi, correct ?
I tried on test-pypi (https://test.pypi.org/project/napari-cellseg3d/) manually with twine, it seems to upload and then install fine, I just want to make sure switching to napari_cellseg3d instead of napari-cellseg3d will not try to upload to a different PyPi project

@C-Achard C-Achard mentioned this pull request May 3, 2024
3 tasks
@C-Achard C-Achard marked this pull request as ready for review May 3, 2024 10:28
@C-Achard C-Achard requested review from CYHSM, MMathisLab and jeylau May 3, 2024 10:28
@MMathisLab
Copy link
Member

this I don't know, but suspect fine -- if you can push it then I think its okay

@C-Achard C-Achard mentioned this pull request May 3, 2024
8 tasks
@MMathisLab MMathisLab removed request for CYHSM and jeylau May 3, 2024 11:07
@C-Achard C-Achard merged commit 5b3dda6 into main May 3, 2024
@MMathisLab MMathisLab deleted the cy/fix-setup-name branch May 3, 2024 17:08
@C-Achard C-Achard added this to the v0.2.0 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Something needs to be or has been fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants