You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// pre-emptively turn on native events since we'll need them
useNativeEvents();
I believe it should not be here, and if really needed, it should be called on the consumer test setup side.
The useNativeEvents( is used to enable the ember-native-dom-helpers, which was needed in the era of moduleFor* tests. Now, for the test suites using modern @ember/test-helpers, I don't think we need it anymore.
Also, useNativeEvents( is now removed in the v2-beta of the ec-page-objects, cause moduleFor test helpers are now removed completelly from @ember/test-helpers, so I think this invocation would break ember-classy-page-object under ember-cli-page-object@v2 when it's released.
So my guess is that we should remove it from here at some point, as a breaking change? @mixonic what do you think?
The text was updated successfully, but these errors were encountered:
I've just observed the following in the codebase
ember-classy-page-object/addon-test-support/-private/page-object.js
Lines 8 to 9 in 714cb45
I believe it should not be here, and if really needed, it should be called on the consumer test setup side.
The
useNativeEvents(
is used to enable the ember-native-dom-helpers, which was needed in the era ofmoduleFor*
tests. Now, for the test suites using modern@ember/test-helpers
, I don't think we need it anymore.Also,
useNativeEvents(
is now removed in the v2-beta of the ec-page-objects, causemoduleFor
test helpers are now removed completelly from@ember/test-helpers
, so I think this invocation would break ember-classy-page-object under ember-cli-page-object@v2 when it's released.So my guess is that we should remove it from here at some point, as a breaking change? @mixonic what do you think?
The text was updated successfully, but these errors were encountered: