Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sticky header CSS position on top navbar #7080

Open
3 tasks done
timheuer opened this issue Jun 17, 2024 · 5 comments
Open
3 tasks done

Enable sticky header CSS position on top navbar #7080

timheuer opened this issue Jun 17, 2024 · 5 comments

Comments

@timheuer
Copy link

timheuer commented Jun 17, 2024

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

The problem

As I've been navigating around in the portal and scrolling I wanted the header to always be there for quick navigation. I have to scroll back up to the top to change filter views, etc. It's small but a delightful UX to have the headers stick.

Proposed solution

Enable CSS sticky positioning on the header

In https://github.com/AdguardTeam/AdGuardHome/blob/master/client/src/components/Header/Header.css#L35-L39, updating Line 35 to:

.header {
    position: sticky;
    top: 0;
    padding: 5px 0;
    z-index: 102;
}

Would result in this experience:

Screen.Recording.2024-06-17.at.3.13.28.PM.mov

Alternatives considered and additional information

No response

@andylau004
Copy link

got it!

i use this code snippet

it works

thks,

@ainar-g ainar-g added the UI label Jun 18, 2024
@timheuer
Copy link
Author

I have a PR ready, but per the contribution guidelines, waiting for maintainer discussion.

@ainar-g
Copy link
Contributor

ainar-g commented Jun 18, 2024

I'm not really sure we'd merge it, at least right now. Even when we make popular UI changes with a lot of 👍 reactions people still come to the issue tracker to complain and ask to revert it back. With a change with unknown level of support, this is even more likely.

Then again, if there are enough positive reactions under this issue, and people really want it, we will merge it. (Please no 👍-only comments, only reactions.)

@timheuer
Copy link
Author

Thanks for expectations @ainar-g! Should I prepare the PR or wait until y'all say you'd take it?

@ainar-g
Copy link
Contributor

ainar-g commented Jun 18, 2024

I feel like it's better to wait. Things can change in the meantime on the front-end side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants