Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics - Remove tracking redirect cancelled event #1901

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

araratthehero
Copy link
Contributor

@araratthehero araratthehero commented Nov 26, 2024

Description

Do not track an error event if the user cancels the redirect flow, since it is not considered an error anymore.

Checklist

  • PR is labelled
  • Code is unit tested
  • Changes are tested manually

COAND-1006

@araratthehero araratthehero added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Nov 26, 2024
@araratthehero araratthehero requested a review from a team as a code owner November 26, 2024 12:10
@araratthehero araratthehero force-pushed the feature/analytics_track_redirect_error_fix branch 2 times, most recently from d02df82 to 48db48d Compare November 26, 2024 12:12
@araratthehero araratthehero changed the title Remove tracking redirect error event when user closes redirect Analytics - Remove tracking redirect error event when user closes redirect Nov 26, 2024
@araratthehero araratthehero changed the title Analytics - Remove tracking redirect error event when user closes redirect Analytics - Remove tracking redirect cancelled event Nov 26, 2024
@araratthehero araratthehero force-pushed the feature/analytics_track_redirect_error_fix branch from 48db48d to 6e3c00b Compare November 27, 2024 15:59
Copy link

✅ No public API changes

Copy link

sonarcloud bot commented Nov 27, 2024

@araratthehero araratthehero merged commit 9a85e78 into develop Nov 27, 2024
11 checks passed
@araratthehero araratthehero deleted the feature/analytics_track_redirect_error_fix branch November 27, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants