Fixed issue of validation #2548
Conversation
|
Please approve workflows |
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
sarfarazbheda
had a problem deploying
to
external
GitHub Actions
Failure
There was a problem hiding this comment.
Hey @sarfarazbheda, Thank you for the PR. We appreciate your contribution to the plugin.
After reviewing your changes, I noticed that the onClick event has been applied to all PaymentMethods. While your approach is commendable, we need to ensure that this event is only triggered for specific PaymentMethods, such as ApplePay, GooglePay, etc.
I would kindly request that you refactor the PR to include it only for the necessary PaymentMethods or else we can handle the refactoring within our team's availability.
There was a problem hiding this comment.
I have checked with all payment methods and working fine. You can test with different methods to confirm.
|
Any update on this issue / PR ? It's been months now and the bug is still present... Thank you. |
|
Hello @sarfarazbheda, Thank you for you contribution and we appreciate all the effort. Unfortunately, this PR can not be merged to due to the reasons explained here. Our team will provide a fix soon to this known bug. Best Regards, |
Description
When the terms and condition checkbox is required field it was not validating the Checkbox.
Tested scenarios
Set terms and condition as required field on the checkout page
Fixes #2547