fix(storage): duplicate goose migration version 25 breaks daemon startup (nightly crash)

[i-trytoohard]

Summary

The AO daemon crashes on startup with a goose: duplicate version 25 detected panic, rendering the nightly desktop build completely unusable. Two migration files claim version 25:

• 0025_worker_idle_outbox.sql (PR fix(lifecycle): durably deliver worker-idle completions to the orchestrator #2836, landed 2026-07-22)
• 0025_session_cleanup_facts.sql (PR feat(storage): add session cleanup-facts table and cleanup_generation (#2811) #2853, landed 2026-07-23)

Error (from the nightly desktop app)

panic: goose: duplicate version 25 detected:
migrations/0025_worker_idle_outbox.sql
migrations/0025_session_cleanup_facts.sql

The UI shows "AO daemon failed to start — Daemon exited with code 2."

Repro

1. Launch the current nightly desktop build (2026-07-23+).
2. Daemon panics during DB migration; app is non-functional.

Root cause

#2836 claimed migration version 25 and landed first. #2853 was developed in parallel and also grabbed 25. Each PR's branch CI saw only one 0025_* file and passed the existing guard test; the collision only materialized once both merged to main.

Fix

Rename the later-landing file to the next free slot (0030):

git mv backend/internal/storage/sqlite/migrations/0025_session_cleanup_facts.sql \
       backend/internal/storage/sqlite/migrations/0030_session_cleanup_facts.sql

The migration is purely additive (a new cleanup_generation column on sessions + a new session_cleanup_facts table with CDC triggers) and has no dependency on 0026–0029, so renumbering to 0030 is safe. Verified locally: TestMigrationVersionsAreUnique passes and the full internal/storage/sqlite test suite is green after the rename.

Why CI didn't catch this

TestMigrationVersionsAreUnique (added in #336) exists exactly to prevent this, and it does fail on the current main state. It passed on each PR because it runs against the PR branch, not the merged state — the classic parallel-PR migration-number collision. Worth considering a merge-time/post-merge check that runs the guard against main head.

/cc @yyovil — this is blocking the nightly. One-line git mv fix.

[somewherelostt]

@neversettle17-101

[somewherelostt]

Thanks for contributing to Agent Orchestrator.

This issue is being picked up by the current external contributor on-call pair:

• @illegalcall
• @Pulkit7070

If someone is already working on this, please continue as usual.
The on-call pair is added for visibility, tracking, and support, not to take over the work.
If you need help with review, direction, reproduction, or next steps, please tag @illegalcall and @Pulkit7070 here.

For faster context or live questions, you can also join the AO Discord.

Join the session here:
https://discord.gg/H6ZDcUXmq

Come by if you want to see what is being built, ask questions, or just hang around with the community.