Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fusdc: ForwardFailed state #10625

Open
0xpatrickdev opened this issue Dec 4, 2024 · 0 comments · May be fixed by #10729
Open

fusdc: ForwardFailed state #10625

0xpatrickdev opened this issue Dec 4, 2024 · 0 comments · May be fixed by #10729
Assignees
@0xpatrickdev
Labels
enhancement New feature or request
Milestone
FU3: multichain i...

Comments

@0xpatrickdev
Copy link
Member

What is the Problem Being Solved?

In FUSDC, the contact does not distinguish between failed forwards and successful ones.

Description of the Design

  • do not call .forwarded () on initiation of forward
    • we considered a Forwarding state, but the extra vstorage write seems unnecessary
  • transition to Forwarded after the transfer vow has fulfilled
  • transition to ForwardFailed after transfer vow has rejected

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xpatrickdev 0xpatrickdev

Labels
enhancement New feature or request
Projects
None yet
Milestone
FU3: multichain integration
Development

Successfully merging a pull request may close this issue.

chore(fusdc): settle ForwardFailed, minted while Advancing, and minted early txs Agoric/agoric-sdk
3 participants
@turadg @dckc @0xpatrickdev