Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map objective UIs #226

Open
Ahli opened this issue Jun 5, 2021 · 1 comment
Open

Fix map objective UIs #226

Ahli opened this issue Jun 5, 2021 · 1 comment

Comments

@Ahli
Copy link
Owner

Ahli commented Jun 5, 2021

Map objective UIs have a lot of issues dealing with player vision changes and replay time jumps.

  • Hanamura
    • fine after own fixes?
  • Alterac Pass
    • partial fix was applied to bar colors. Now only the highlighting is wrong
    • the growing bar is not bound to game time thus a pause will make the animation wrong
    • team icon is sometimes dark and becomes brighter again during vision changes
    • replay time jumps can make the objective UI hide (growing stage => jump to capture stage)
  • Cursed Hollow
    • messages are directed to the player "your/enemy"
  • Towers of Doom:
    • notification can stay visible "Cannons are firing"
    • notification names "enemy/your cannons"
  • Garden of Terror
    • icons below the minimap (open/closed seed icons) not shown FIXED
    • wrong color in icon next to the health bars while plants are attacking. The bar's color is correct FIXED
    • replay time jumps make labels not appear (terrors -> no terrors => hidden seed counter) FIXED
    • replay time jumps make notifications visible when terrors are alive (not active -> active)
  • Tomb of the Spider Queen
    • health icon color wrong FIXED only wrong during red vision; flame animation is not sync as I had to use 2 image frames because stategroup actions cannot set a texture for a layer only
    • "enemy webweaver's summoned" notification
  • Dragon Shire
    • fine?
  • Blackheart's Bay
    • fine?
  • Battlefield Of Eternity
    • fine?
  • Braxis Holdout
    • fine?
  • Haunted Mines
    • while golem is alive, in red vision, the bars and the skull count next to it are flipped FIXED
  • Infernal Shrines
    • fine?
  • Sky Temple
    • fine?
  • Volskays Foundry
    • replay time jump can make "control point will unlock" panel + timer appear persistently above other phases (protector alive -> capturing phase => notification UI visible)
    • same after protector dies => time jumps cause all other panels to become visible
  • Warhead Junction
    • fine?

TODO complete the list of issues, fix the issues

@Ahli
Copy link
Owner Author

Ahli commented Feb 19, 2022

Alterac Pass' states cannot be fixed using the states as the trigger script sets it based on the team (own team is top bar, enemy team is bottom bar):

  1. watch blue capture => top bar state from 00 to 10
  2. switch to red vision
  3. red captures => top bar state from 10 to 10, undetectable

Workaround ideas:

  • is the state saved in galaxy variables? Can they be output in a label and checked?
  • For the notifications an EventID is set. That contains info about the most recent capture. But no info about contested.
    • 11 => blueCap: false
    • 12 => redCap: true
    • 21 => blueCap: true
    • 22 => redCap: false
    • the above eventID is correct when the notification frame becomes visible
    • !blueCap && redCap => blue highlight
    • blueCap && !redCap => red highlight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant