Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Drift animation #3813

Closed
1 task done
BaptisteHudyma opened this issue Mar 12, 2024 · 2 comments
Closed
1 task done

Fix the Drift animation #3813

BaptisteHudyma opened this issue Mar 12, 2024 · 2 comments
Labels
bug cannot reproduce Developers are not able reproduce. Might be fixed already, or report is missing important details

Comments

@BaptisteHudyma
Copy link

What happened?

Hello !
The drift animation does not work as expected, only the lower right quarter is displayed.

To Reproduce Bug

To reproduce: try it.

Expected Behavior

The whole animation is displayed, instead of just a quarter of it

Install Method

Self-Compiled

What version of WLED?

0.14.1

Which microcontroller/board are you seeing the problem on?

Other

Relevant log/trace output

No response

Anything else?

The bug is due to a rounding error with a cast to uint16_t instead of int16_t, MR to come

Code of Conduct

  • I agree to follow this project's Code of Conduct
@BaptisteHudyma
Copy link
Author

BaptisteHudyma commented Mar 12, 2024

I opened MR #3816 to fix this issue

@blazoncek blazoncek added the cannot reproduce Developers are not able reproduce. Might be fixed already, or report is missing important details label Mar 12, 2024
@blazoncek
Copy link
Collaborator

Implemented via #3816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cannot reproduce Developers are not able reproduce. Might be fixed already, or report is missing important details
Projects
None yet
Development

No branches or pull requests

2 participants