Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plasma effect on random palet devolves into flickering chaos #3870

Closed
1 task done
Matt2D3 opened this issue Mar 31, 2024 · 6 comments · Fixed by #3880
Closed
1 task done

plasma effect on random palet devolves into flickering chaos #3870

Matt2D3 opened this issue Mar 31, 2024 · 6 comments · Fixed by #3880
Labels
bug effect fixed in source This issue is unsolved in the latest release but fixed in master

Comments

@Matt2D3
Copy link

Matt2D3 commented Mar 31, 2024

What happened?

after setting the effect to plasma and the color palette to random cycle, it works fine until the next day, where the palette becomes mostly red but flickers to blue occasionally. this happens on esp32 with WLED_0.15.0-b1_ESP32 firmware and can only be resolved by a reboot

To Reproduce Bug

use esp32 and WLED_0.15.0-b1_ESP32
use random cycle palette
I have only tested with the plasma effect, but given the changes to palette blending it will most likely happen on other effects

Expected Behavior

the random cycle palette should be consistent after the first few hours

Install Method

Binary from WLED.me

What version of WLED?

WLED_0.15.0-b1_ESP32.bin

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

this happens on 3 different setups. all use esp32 with WLED_0.15.0-b1_ESP32 firmware, will test esp8266 with equivalent firmware soon

Code of Conduct

  • I agree to follow this project's Code of Conduct
@blazoncek
Copy link
Collaborator

@DedeHai can you take a look?

@DedeHai
Copy link
Collaborator

DedeHai commented Apr 2, 2024

so how long does this take until it happens? currently running 12h and still works fine.

@Matt2D3
Copy link
Author

Matt2D3 commented Apr 3, 2024

it takes around 16h to occour
also I tested it and it does occur on the esp8266.
this bug also persists across effects, so it seems to be an issue with pallet switching specifically (triggered bug through plasma, bug continued when switching to noise 1)

DedeHai added a commit to DedeHai/WLED that referenced this issue Apr 5, 2024
millis()/1000 rollover after 18h was not handled, truncating to 16bits after division fixes it.
@DedeHai
Copy link
Collaborator

DedeHai commented Apr 5, 2024

Thanks for finding and reporting this. I wrote up a test and was able to reproduce it now. Problem is an unhandled millis() rollover, causing the palette to fade uncontrollably. It's an easy fix. (PR submitted)

@blazoncek blazoncek linked a pull request Apr 5, 2024 that will close this issue
@blazoncek
Copy link
Collaborator

@Matt2D3 please test #3880

@blazoncek blazoncek added the fixed in source This issue is unsolved in the latest release but fixed in master label Apr 10, 2024
@Matt2D3
Copy link
Author

Matt2D3 commented Apr 13, 2024

beta 2 is working correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug effect fixed in source This issue is unsolved in the latest release but fixed in master
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants