Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 and MQTT support. #7

Open
stenjo opened this issue Jan 17, 2019 · 8 comments · May be fixed by #8
Open

Python 3 and MQTT support. #7

stenjo opened this issue Jan 17, 2019 · 8 comments · May be fixed by #8

Comments

@stenjo
Copy link

stenjo commented Jan 17, 2019

I have created a fork that runs on python3 and also has support for publishing data onto an mqtt server.
Would this be of interest to add to this project?

@orjangj
Copy link
Contributor

orjangj commented Jan 17, 2019

Hi stenjo,

Great suggestion on adding python3 support.

I would suggest we do this by making the script compatible with both py2 and py3. E.g. by using the "six" python module, instead of having multiple scripts.

Anyway, I'm on leave until next week, so I wont be able to review your suggestions in more detail until then.

@stenjo
Copy link
Author

stenjo commented Jan 19, 2019

Just tested my fork with both python 2 anf python 3 and both seems to be working. Should i make a pull-request so you could evaluate?

@stenjo stenjo linked a pull request Jan 19, 2019 that will close this issue
@jjanderson
Copy link

Hi,

Is this available yet? Specifically looking for MQTT support.

Thanks

@stenjo
Copy link
Author

stenjo commented Jan 20, 2020

Have not had the time to update this PR according to orjangj's request but it works continuously in my apps at home. pulling info every 10 minutes or so.
Have not managed to make it work with the latest 2nd Gen firmware - but otherwise OK.
#8

@jjanderson
Copy link

Thanks for hte update. Are you able to detail the MQTT message topics generated that one needs to subscribe to in order to get the sensor data?

@stenjo
Copy link
Author

stenjo commented Jan 20, 2020

In the PR there is an waveplus.items file containing the openhab items definitions. There you will find indications on the topics the information is published on.
The README.md file contains a more detailed description of the format.

@jjanderson
Copy link

any idea when this will be merged?

@stenjo
Copy link
Author

stenjo commented Feb 5, 2020

Currently, I'm thinking most likely not.
Python 2.7 is no longer supported, and the repo owner is not happy adding the MQTT support to this. In addition it seems to be an issue with Gen 2 devices - that I have not had time or the opportunity to fix.
My suggestion is to use this PR as your source if it contains features you need - otherwise you are advised to use the original code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants