Skip to content

Commit 0107b32

Browse files
committed
feat: #37 본인인증코드 발송 API 응답에 성공 여부 추가
1 parent ac2b97a commit 0107b32

File tree

3 files changed

+19
-4
lines changed

3 files changed

+19
-4
lines changed

src/main/java/com/ajou/hertz/common/auth/controller/AuthController.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import com.ajou.hertz.common.auth.dto.request.LoginRequest;
1414
import com.ajou.hertz.common.auth.dto.request.SendUserAuthCodeRequest;
1515
import com.ajou.hertz.common.auth.dto.response.JwtTokenInfoResponse;
16+
import com.ajou.hertz.common.auth.dto.response.SendUserAuthCodeResponse;
1617
import com.ajou.hertz.common.auth.service.AuthService;
1718
import com.ajou.hertz.common.auth.service.UserAuthCodeService;
1819
import com.ajou.hertz.common.kakao.service.KakaoService;
@@ -77,12 +78,12 @@ public JwtTokenInfoResponse kakaoLoginV1(@RequestBody @Valid KakaoLoginRequest k
7778
"""
7879
)
7980
@ApiResponses({
80-
@ApiResponse(responseCode = "204"),
81+
@ApiResponse(responseCode = "200"),
8182
@ApiResponse(responseCode = "Any", description = "[1002] 인증 코드 문자 발송 과정 중 오류가 발생한 경우", content = @Content)
8283
})
8384
@PostMapping(value = "/codes/send", headers = API_VERSION_HEADER_NAME + "=" + 1)
84-
public ResponseEntity<Void> sendUserAuthCodeV1(@RequestBody @Valid SendUserAuthCodeRequest sendCodeRequest) {
85+
public SendUserAuthCodeResponse sendUserAuthCodeV1(@RequestBody @Valid SendUserAuthCodeRequest sendCodeRequest) {
8586
userAuthCodeService.sendUserAuthCodeViaSms(sendCodeRequest.getPhoneNumber());
86-
return ResponseEntity.noContent().build();
87+
return new SendUserAuthCodeResponse(true);
8788
}
8889
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
package com.ajou.hertz.common.auth.dto.response;
2+
3+
import lombok.AccessLevel;
4+
import lombok.AllArgsConstructor;
5+
import lombok.Getter;
6+
import lombok.NoArgsConstructor;
7+
8+
@AllArgsConstructor
9+
@NoArgsConstructor(access = AccessLevel.PRIVATE)
10+
@Getter
11+
public class SendUserAuthCodeResponse {
12+
13+
private Boolean isSuccess;
14+
}

src/test/java/com/ajou/hertz/unit/common/auth/controller/AuthControllerTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public AuthControllerTest(MockMvc mvc, ObjectMapper objectMapper) {
106106
.contentType(MediaType.APPLICATION_JSON)
107107
.content(objectMapper.writeValueAsString(sendCodeRequest))
108108
)
109-
.andExpect(status().isNoContent());
109+
.andExpect(status().isOk());
110110
then(userAuthCodeService).should().sendUserAuthCodeViaSms(phoneNumber);
111111
verifyEveryMocksShouldHaveNoMoreInteractions();
112112
}

0 commit comments

Comments
 (0)