Skip to content

Commit 3101ace

Browse files
committed
refactor: #73 불필요한 코드 제거 및 수정
1 parent 1199bcb commit 3101ace

File tree

2 files changed

+0
-33
lines changed

2 files changed

+0
-33
lines changed

src/test/java/com/ajou/hertz/unit/domain/user/service/UserCommandServiceTest.java

-18
Original file line numberDiff line numberDiff line change
@@ -206,24 +206,6 @@ static Stream<Arguments> testDataForCreateNewUserWithKakao() throws Exception {
206206
verifyEveryMocksShouldHaveNoMoreInteractions();
207207
}
208208

209-
@Test
210-
void 주어진_유저_ID와_이미지_URL로_유저의_프로필_이미지를_업데이트한다_존재하지_않는_유저라면_예외가_발생한다() throws Exception {
211-
// Given
212-
Long userId = 1L;
213-
MultipartFile profileImage = new MockMultipartFile("file", "test.jpg", "image/jpeg",
214-
"test image content".getBytes());
215-
216-
given(userQueryService.getById(userId)).willThrow(UserNotFoundByIdException.class);
217-
218-
// When
219-
Throwable t = catchThrowable(() -> sut.updateUserProfileImage(userId, profileImage));
220-
221-
// Then
222-
then(userQueryService).should().getById(userId);
223-
verifyEveryMocksShouldHaveNoMoreInteractions();
224-
assertThat(t).isInstanceOf(UserNotFoundByIdException.class);
225-
}
226-
227209
@Test
228210
void 주어진_유저_ID와_연락_수단으로_연락_수단을_변경한다() throws Exception {
229211
// given

src/test/java/com/ajou/hertz/unit/domain/user/service/UserProfileImageCommandServiceTest.java

-15
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import org.mockito.Mock;
1414
import org.mockito.junit.jupiter.MockitoExtension;
1515
import org.springframework.mock.web.MockMultipartFile;
16-
import org.springframework.security.crypto.password.PasswordEncoder;
1716
import org.springframework.test.context.event.annotation.BeforeTestMethod;
1817
import org.springframework.web.multipart.MultipartFile;
1918

@@ -25,9 +24,7 @@
2524
import com.ajou.hertz.domain.user.entity.User;
2625
import com.ajou.hertz.domain.user.entity.UserProfileImage;
2726
import com.ajou.hertz.domain.user.repository.UserProfileImageRepository;
28-
import com.ajou.hertz.domain.user.repository.UserRepository;
2927
import com.ajou.hertz.domain.user.service.UserProfileImageCommandService;
30-
import com.ajou.hertz.domain.user.service.UserQueryService;
3128
import com.ajou.hertz.util.ReflectionUtils;
3229

3330
@DisplayName("[Unit] Service(Command) - User Profile Image")
@@ -36,18 +33,9 @@ public class UserProfileImageCommandServiceTest {
3633
@InjectMocks
3734
private UserProfileImageCommandService sut;
3835

39-
@Mock
40-
private UserQueryService userQueryService;
41-
42-
@Mock
43-
private UserRepository userRepository;
44-
4536
@Mock
4637
private UserProfileImageRepository userProfileImageRepository;
4738

48-
@Mock
49-
private PasswordEncoder passwordEncoder;
50-
5139
@Mock
5240
private HertzProperties hertzProperties;
5341

@@ -120,9 +108,6 @@ public void setUp() {
120108
}
121109

122110
private void verifyEveryMocksShouldHaveNoMoreInteractions() {
123-
then(userQueryService).shouldHaveNoMoreInteractions();
124-
then(userRepository).shouldHaveNoMoreInteractions();
125-
then(passwordEncoder).shouldHaveNoMoreInteractions();
126111
then(fileService).shouldHaveNoMoreInteractions();
127112
}
128113

0 commit comments

Comments
 (0)