refactor: #72 403 에러 검증 로직 제거

Author: tinon1004

src/main/java/com/ajou/hertz/domain/user/controller/UserController.java

@@ -127,7 +127,7 @@ public UserResponse updateContactLinkV1(
 		@RequestBody @Valid UpdateContactLinkRequest updateContactLinkRequest,
 		@AuthenticationPrincipal UserPrincipal userPrincipal
 	) {
-		UserDto userUpdated = userCommandService.updateContactLink(userPrincipal.getUserId(), userPrincipal.getUserId(),
+		UserDto userUpdated = userCommandService.updateContactLink(userPrincipal.getUserId(),
 			updateContactLinkRequest.getContactLink());
 		return UserResponse.from(userUpdated);
 	}

src/main/java/com/ajou/hertz/domain/user/exception/UserIdForbiddenException.java

@@ -14,7 +14,6 @@
 import com.ajou.hertz.domain.user.dto.request.SignUpRequest;
 import com.ajou.hertz.domain.user.entity.User;
 import com.ajou.hertz.domain.user.exception.UserEmailDuplicationException;
-import com.ajou.hertz.domain.user.exception.UserIdForbiddenException;
 import com.ajou.hertz.domain.user.exception.UserKakaoUidDuplicationException;
 import com.ajou.hertz.domain.user.exception.UserPhoneDuplicationException;
 import com.ajou.hertz.domain.user.repository.UserRepository;
@@ -134,18 +133,12 @@ private String generateRandom16CharString() {
 	/**
 	 *연락 수단을 변경합니다.
 	 *
-	 * @param loginUserId API를 호출한 유저의 ID
-	 * @param userId 변경하고자 하는 유저의 ID
+	 * @param userId 유저의 ID
 	 * @param contactLink 변경할 연락 수단
-	 *@throws UserIdForbiddenException 유저ID가 일치하지 않는 경우
 	 *
 	 *@return 변경된 유저 정보
 	 */
-	public UserDto updateContactLink(Long loginUserId, Long userId, String contactLink) {
-		if (!loginUserId.equals(userId)) {
-			User user = userQueryService.getById(userId);
-			throw new UserIdForbiddenException(userId, loginUserId);
-		}
+	public UserDto updateContactLink(Long userId, String contactLink) {
 		User user = userQueryService.getById(userId);
 		user.changeContactLink(contactLink);
 		return UserDto.from(user);

src/main/java/com/ajou/hertz/domain/user/service/UserCommandService.java

@@ -219,7 +219,7 @@ public void securitySetUp() throws Exception {
 		String newContactLink = "https://new-contact-link.com";
 		UserDto expectedResult = createUserDto(userId);
 		UserDetails testUser = createTestUser(userId);
-		given(userCommandService.updateContactLink(anyLong(), anyLong(), anyString())).willReturn(expectedResult);
+		given(userCommandService.updateContactLink(anyLong(), anyString())).willReturn(expectedResult);
 
 		// when & then
 		mvc.perform(
@@ -231,7 +231,7 @@ public void securitySetUp() throws Exception {
 			)
 			.andExpect(status().isOk())
 			.andExpect(jsonPath("$.contactLink").value(expectedResult.getContactLink()));
-		then(userCommandService).should().updateContactLink(userId, userId, newContactLink);
+		then(userCommandService).should().updateContactLink(userId, newContactLink);
 		verifyEveryMocksShouldHaveNoMoreInteractions();
 	}
 

src/test/java/com/ajou/hertz/unit/domain/user/controller/UserControllerTest.java

@@ -28,7 +28,6 @@
 import com.ajou.hertz.domain.user.dto.request.SignUpRequest;
 import com.ajou.hertz.domain.user.entity.User;
 import com.ajou.hertz.domain.user.exception.UserEmailDuplicationException;
-import com.ajou.hertz.domain.user.exception.UserIdForbiddenException;
 import com.ajou.hertz.domain.user.exception.UserKakaoUidDuplicationException;
 import com.ajou.hertz.domain.user.exception.UserNotFoundByIdException;
 import com.ajou.hertz.domain.user.exception.UserPhoneDuplicationException;
@@ -182,7 +181,7 @@ static Stream<Arguments> testDataForCreateNewUserWithKakao() throws Exception {
 		given(userQueryService.getById(userId)).willReturn(user);
 
 		// when
-		UserDto updatedUserDto = sut.updateContactLink(userId, userId, contactLink);
+		UserDto updatedUserDto = sut.updateContactLink(userId, contactLink);
 
 		// then
 		then(userQueryService).should().getById(userId);
@@ -198,32 +197,14 @@ static Stream<Arguments> testDataForCreateNewUserWithKakao() throws Exception {
 		given(userQueryService.getById(userId)).willThrow(UserNotFoundByIdException.class);
 
 		// when
-		Throwable t = catchThrowable(() -> sut.updateContactLink(userId, userId, contactLink));
+		Throwable t = catchThrowable(() -> sut.updateContactLink(userId, contactLink));
 
 		// then
 		then(userQueryService).should().getById(userId);
 		verifyEveryMocksShouldHaveNoMoreInteractions();
 		assertThat(t).isInstanceOf(UserNotFoundByIdException.class);
 	}
 
-	@Test
-	void 주어진_유저_ID가_API를_호출한_유저의_ID와_일치하지_않는다면_에러가_발생한다() throws Exception {
-		// given
-		Long loginUserId = 1L;
-		Long userId = 2L;
-		String contactLink = "https://new-contactLink";
-		User user = createUser(userId, "$2a$abc123", "12345");
-		given(userQueryService.getById(userId)).willReturn(user);
-
-		// when
-		Throwable t = catchThrowable(() -> sut.updateContactLink(loginUserId, userId, contactLink));
-
-		// then
-		assertThat(t).isInstanceOf(UserIdForbiddenException.class);
-		then(userQueryService).should().getById(userId);
-		verifyEveryMocksShouldHaveNoMoreInteractions();
-	}
-
 	private void verifyEveryMocksShouldHaveNoMoreInteractions() {
 		then(userQueryService).shouldHaveNoMoreInteractions();
 		then(userRepository).shouldHaveNoMoreInteractions();