Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better File Dialog for Linux #1362

Open
benjamin-kirkbride opened this issue Jul 10, 2023 · 2 comments
Open

Better File Dialog for Linux #1362

benjamin-kirkbride opened this issue Jul 10, 2023 · 2 comments
Assignees
Labels

Comments

@benjamin-kirkbride
Copy link
Contributor

          TIL that it tk uses native file dialogs on not-linux...

Yes, agree completely with everything @rdbende said. My thoughts is it should work like this:

  1. if windows or mac use default filedialog as now; if linux continue
  2. check config to see what user wants to do; if no config set continue
  3. try zenity
  4. try kdialog
  5. try tkfilebrowser (optional install?)
  6. fallback to default tk.filedialog

Originally posted by @benjamin-kirkbride in #1358 (comment)

@rdbende
Copy link
Collaborator

rdbende commented Jul 10, 2023

I have some stuff with kdialog and zenity here:

https://github.com/tukaan/tukaan/blob/master/tukaan/dialogs/filedialog.py

Though we don't need this many options fortunately.

@rdbende rdbende self-assigned this Jul 10, 2023
@Akuli
Copy link
Owner

Akuli commented Jul 11, 2023

  1. try zenity
  2. try kdialog

This might not be great if you have both installed, but you are currently using KDE. Maybe we could try kdialog first and then zenity, if according to environment variables Porcupine is running in KDE.

But I don't have KDE, so I don't know how well zenity works on KDE. Maybe it works fine and we can always try it first :)

  1. try tkfilebrowser (optional install?)

I think this isn't necessary. We already have a sudo apt install line in the linux instructions, so we might as well tell people to install zenity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants