Aleph One does not build with newer OpenAL

[brad0]

After updating to OpenAL 1.24.x we noticed Aleph One stopped building. Using Clang 16.

c++ -DHAVE_CONFIG_H -I. -I../..  -I../../Source_Files/CSeries -I../../Source_Files/GameWorld -I../../Source_Files/Input -I../../Source_Files/Misc -I../../Source_Files/ModelView -I../../Source_Files/Network -I../../Source_Files/Network/Metaserver -I../../Source_Files/TCPMess -I../../Source_Files/RenderMain -I../../Source_Files/RenderOther -I../../Source_Files/Sound -I../../Source_Files/XML -I../../Source_Files -I/usr/local/include/libpng16 -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/SDL2 -I/usr/local/include -DHWY_SHARED_DEFINE -DAVIF_DLL -I/usr/local/include/webp -I/usr/X11R6/include -D_REENTRANT -I/usr/local/include -I/usr/local/include/AL -I/usr/local/include -I/usr/local/include/opus  -I/usr/local/include/SDL2 -I/usr/X11R6/include -D_REENTRANT -I/usr/local/include/SDL2 -I/usr/X11R6/include -D_REENTRANT -I/usr/local/include -I/usr/local/include/SDL2 -I/usr/X11R6/include -D_REENTRANT -DSDL  -O2 -pipe -MT game_wad.o -MD -MP -MF $depbase.Tpo -c -o game_wad.o game_wad.cpp &&\
mv -f $depbase.Tpo $depbase.Po
In file included from game_wad.cpp:102:
In file included from ../../Source_Files/Misc/preferences.h:59:
In file included from ../../Source_Files/Sound/SoundManager.h:29:
In file included from ../../Source_Files/Sound/SoundPlayer.h:4:
In file included from ../../Source_Files/Sound/AudioPlayer.h:5:
/usr/local/include/AL/alext.h:821:90: error: expected ')'
typedef void (AL_APIENTRY *LPALGENEFFECTSDIRECT)(ALCcontext *context, ALsizei n, ALuint *effects) AL_API_NOEXCEPT17;
                                                                                         ^
../../Source_Files/GameWorld/effects.h:156:28: note: expanded from macro 'effects'
#define effects (EffectList.data())
                           ^
/usr/local/include/AL/alext.h:821:90: note: to match this '('
../../Source_Files/GameWorld/effects.h:156:17: note: expanded from macro 'effects'
#define effects (EffectList.data())
                ^
In file included from game_wad.cpp:102:
In file included from ../../Source_Files/Misc/preferences.h:59:
In file included from ../../Source_Files/Sound/SoundManager.h:29:
In file included from ../../Source_Files/Sound/SoundPlayer.h:4:
In file included from ../../Source_Files/Sound/AudioPlayer.h:5:
/usr/local/include/AL/alext.h:822:99: error: expected ')'
typedef void (AL_APIENTRY *LPALDELETEEFFECTSDIRECT)(ALCcontext *context, ALsizei n, const ALuint *effects) AL_API_NOEXCEPT17;
                                                                                                  ^
../../Source_Files/GameWorld/effects.h:156:28: note: expanded from macro 'effects'
#define effects (EffectList.data())
                           ^
/usr/local/include/AL/alext.h:822:99: note: to match this '('
../../Source_Files/GameWorld/effects.h:156:17: note: expanded from macro 'effects'
#define effects (EffectList.data())
                ^
2 errors generated.

[brad0]

https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/games/alephone/alephone/patches/patch-Source_Files_GameWorld_effects_h?rev=1.1&hideattic=1

For the workaround for now. I would expect changing the macro name would be preferred.