Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M1 Map: Blessed and Broken failing #533

Open
MaddTheSane opened this issue Feb 17, 2025 · 1 comment
Open

M1 Map: Blessed and Broken failing #533

MaddTheSane opened this issue Feb 17, 2025 · 1 comment

Comments

@MaddTheSane
Copy link
Contributor

I encountered a lot of old Marathon 1 and M1A1 maps at https://archive.org/details/UltimateMarathonMaps specifically the file called "Marathon 1 + M1A1 Net + Solo Maps.zip" and have encountered a few that do not work Aleph one. Most of the errors are due to a "Detached polygon". Attached is the specific map mentioned, but there may be more: Blessed and Broken 1.0 - M1.zip

/Users/runner/work/alephone/alephone/Source_Files/GameWorld/flood_map.cpp:187: Assertion failed: !POLYGON_IS_DETACHED(polygon)

This does lead me to wonder how Aleph One should handle malformed maps that seemed to run fine under Marathon 1. Should we work around the buggy files or just flat-out refuse to run bad maps. How it handles it currently is an assertion and then a crash. Perhaps a warning about a bad map and going back to the main menu would be better?

@treellama
Copy link
Member

Assertion failures aren't crashes, but yes, long term the goal should be to handle invalid maps with an error message and a return to the main screen. Many M1 maps were created in unofficial editors that set invalid flags, that's likely the case with Blessed and Broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants