Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Updated analysis: independent rna sample list selection #1103

Open
kgaonkar6 opened this issue Jun 23, 2021 · 5 comments
Open

Updated analysis: independent rna sample list selection #1103

kgaonkar6 opened this issue Jun 23, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@kgaonkar6
Copy link
Collaborator

kgaonkar6 commented Jun 23, 2021

What analysis module should be updated and why?

An incorrect matching here:

independent_dna <- histology_df %>%
# include matched independent_dna samples
dplyr::filter(Kids_First_Biospecimen_ID %in%
independent_dna_sample_df$Kids_First_Biospecimen_ID)

The filtered rnaseq samples histology_df above will not have any dna biospecimen ids that match so it will be an empty dataframe.

What changes need to be made? Please provide enough detail for another participant to make the update.

The code here:

independent_dna <- histology_df %>%
# include matched independent_dna samples
dplyr::filter(Kids_First_Biospecimen_ID %in%
independent_dna_sample_df$Kids_First_Biospecimen_ID)

should actually map to Kids_First_Participant_ID

 independent_dna <- histology_df %>%
    # include matched independent_dna samples
    dplyr::filter(Kids_First_Participant_ID %in%
                    independent_dna_sample_df$Kids_First_Participant_ID)

What input data should be used? Which data were used in the version being updated?

pbta-histologies.tsv

When do you expect the revised analysis will be completed?

~1/2 day

Who will complete the updated analysis?

@kgaonkar6

@jharenza
Copy link
Collaborator

@logstar can you work on this?

1 similar comment
@jharenza
Copy link
Collaborator

@logstar can you work on this?

@logstar
Copy link
Contributor

logstar commented Jul 16, 2021

@logstar can you work on this?

Sure. I can work on this.

@kgaonkar6 kgaonkar6 added bug Something isn't working and removed blocking release updated analysis labels Jul 22, 2021
@kgaonkar6
Copy link
Collaborator Author

This is low priority @logstar so I think you can move this from your to-do list for now.

@logstar
Copy link
Contributor

logstar commented Jul 22, 2021

This is low priority @logstar so I think you can move this from your to-do list for now.

Thank you for letting me know @kgaonkar6 ! I will work on this after finishing some ongoing PedOT work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants