Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Add MATLAB Runtime and the relevant MATLAB programs to project Docker container #529

Closed
jaclyn-taroni opened this issue Feb 10, 2020 · 6 comments
Assignees
Labels
Docker-software Use this label for help getting certain software into the docker container in progress Someone is working on this issue, but feel free to propose an alternative approach!

Comments

@jaclyn-taroni
Copy link
Member

We currently run GISTIC upstream of the project. It would be great to include the GISTIC steps in the project repository, as that would give us a better opportunity to document and encapsulate the entire CNA analysis file pipeline and give us more flexibility for how GISTIC is run (e.g., on individual histologies with larger sample sizes, different parameters for a broad change) if desired. Notably, we may also want to use something like MutSigCV (#517) and that would have similar constraints (more on that below).

To include the GISTIC or MutSigCV steps within the project, we will need to install these on the project Docker container. Both of these programs appear to have executable versions that can be run if the MATLAB Compiler Runtime libraries are installed.

From the GISTIC README.txt:

The executable is the gene pattern module 'gp_gistic2_from_seg'. This
module depends on the libraries in the MATLAB Compiler Runtime (MCR)
version 8.3 (R2014a).

And from the MutSig documentation:

If you do not have a license for Matlab, you can run the compiled version of MutSigCV using the free Matlab MCR:

run_MutSigCV.sh <path_to_MCR> mutations.maf coverage.txt covariates.txt output.txt

At least GISTIC comes with an MCR Installer, but the size of that installation is non-negligible (~0.5 GB), so we should plan to install it once and symlink it to the individual tools' folders.

Here is an example Dockerfile for MCR: https://hub.docker.com/r/usuresearch/matlab-runtime/dockerfile (H/T @cgreene)

@jaclyn-taroni jaclyn-taroni added the Docker-software Use this label for help getting certain software into the docker container label Feb 10, 2020
@jaclyn-taroni
Copy link
Member Author

I am going to look into this today.

@jaclyn-taroni jaclyn-taroni self-assigned this Feb 10, 2020
@jaclyn-taroni jaclyn-taroni added the in progress Someone is working on this issue, but feel free to propose an alternative approach! label Feb 10, 2020
@jaclyn-taroni
Copy link
Member Author

@jharenza - relevant to this issue but also more generally - what is the markers file used here: https://github.com/d3b-center/OpenPBTA-workflows/blob/cb87a2b725d0e41d34a88436492830802c40f7f0/bash/run-gistic.sh#L16

@jaclyn-taroni
Copy link
Member Author

It seems like it might be optional?

@jharenza
Copy link
Collaborator

@jaclyn-taroni yes- markers are the original SNP markers used in the SNP array, and is optional - the program generates psuedo-markers, so I really should not have that in the command. Same with the array file - optional, that is to list which samples you want to run, rather than creating a seg each time.I had used in the past but never took that out of the command. Interestingly, GISTIC doesn't care if you have these extra commands (just sloppy), but hollers if you have many other issues in your files!

@jaclyn-taroni
Copy link
Member Author

@jharenza can you take a gander at #535? I believe I have all the parameters the same as the other runs with the extra commands removed.

@jaclyn-taroni
Copy link
Member Author

Closing this – the GISTIC portion was addressed in #535 and anything else we've considered adding (so far) is subsumed by #545 and #546.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Docker-software Use this label for help getting certain software into the docker container in progress Someone is working on this issue, but feel free to propose an alternative approach!
Projects
None yet
Development

No branches or pull requests

2 participants