Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use is_manifold_like #228

Open
lukem12345 opened this issue May 16, 2024 · 0 comments
Open

Use is_manifold_like #228

lukem12345 opened this issue May 16, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@lukem12345
Copy link
Member

lukem12345 commented May 16, 2024

CombinatorialSpaces.jl offers the is_manifold_like function which tests certain combinatorial-properties of a manifold-like simplicial set. (Note that some not-tested-for-properties, such as whether a manifold is a single connected component, do not obstruct us simulating physics on them.)

We should call is_manifold_like as part of our gensim pipeline. This will catch bugs early and provide helpful error messages.

Note that is_manifold_like uses the older d reference implementation, and so using dec_differential there should be upstreamed.

@lukem12345 lukem12345 added the enhancement New feature or request label May 16, 2024
@lukem12345 lukem12345 self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant