Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud-first FMS branch should be backwards compatible #378

Open
pgarrison opened this issue Dec 20, 2024 · 1 comment
Open

Cloud-first FMS branch should be backwards compatible #378

pgarrison opened this issue Dec 20, 2024 · 1 comment

Comments

@pgarrison
Copy link
Contributor

pgarrison commented Dec 20, 2024

As currently designed, the cloud-first FMS features will cause breakages if used with the pre-cloud-first FMS ETL pipeline. But the cloud-first FMS ETL pipeline changes will cause breakages if used with the pre-cloud-first BFF. To enable a smooth migration, the BFF features should all be backwards compatible.

This is because the file_path is now the cloud path, which will break key features like opening a file in a viewer or downloading a file.

With this backwards compatibility, the following migration is possible.

  1. Announce the new BFF version, and give people some time (a day?) to download it.
  2. Deploy the ETL changes.

Without this backwards compatibility, we might have to accept that BFF will temporarily be broken for internal users.

@pgarrison
Copy link
Contributor Author

pgarrison commented Dec 21, 2024

This would look like adding a bunch of feature detection conditionals to the code from #370, #376, and #377.

if (file has a "Should Be In Local" annotation) {
     do the new behavior
} else {
     do the old behavior
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant