Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding customized dendrogram in buildPatchseqTaxonomy() #15

Open
xuehanci opened this issue Apr 3, 2024 · 2 comments
Open

Adding customized dendrogram in buildPatchseqTaxonomy() #15

xuehanci opened this issue Apr 3, 2024 · 2 comments
Assignees

Comments

@xuehanci
Copy link
Collaborator

xuehanci commented Apr 3, 2024

buildTaxonomy() is able to take in the existing dendrogram associated with the taxonomy, but buildPatchseqTaxonomy() doesn’t have this feature. It would be helpful to add a feature in buildPatchseqTaxonomy() to take in an existing patcheq dendrogram as well.

In the previous code that used the tree-mapping method for the mouse VISp taxonomy, a consolidated/collapsed dendrogram (where a branch could have more than two children) was used, which at the time improved mapping performance. For consistency with the past work, it would be good to be able to use the same dendrogram for that kind of mapping.

We could also have checks to ensure that the collapsed dendrogram given as input has a structure consistent with the original dendrogram and that it includes all the expected types.

@UCDNJJ
Copy link
Collaborator

UCDNJJ commented Apr 9, 2024

I think this is a great addition, would you be up for implementing these changes under the recent updates?

@xuehanci
Copy link
Collaborator Author

I think this is a great addition, would you be up for implementing these changes under the recent updates?

Yes, I would be up to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants