From bc7051d8c42e6fc0852e1529734647d7eb121645 Mon Sep 17 00:00:00 2001 From: bruno-f-cruz <7049351+bruno-f-cruz@users.noreply.github.com> Date: Thu, 6 Jun 2024 13:34:50 -0700 Subject: [PATCH 1/4] Fix example --- examples/aind_manipulator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/aind_manipulator.py b/examples/aind_manipulator.py index 1d0aa989..851591d9 100644 --- a/examples/aind_manipulator.py +++ b/examples/aind_manipulator.py @@ -36,7 +36,7 @@ ) rig = m.CalibrationRig( - harp_manipulator=m.AindManipulatorDevice(port_name="COM4"), + manipulator=m.AindManipulatorDevice(port_name="COM4", calibration=calibration_data), rig_name="AindManipulatorRig", ) From 57e99da260397b4ddee232c1f73bbff86cee283f Mon Sep 17 00:00:00 2001 From: bruno-f-cruz <7049351+bruno-f-cruz@users.noreply.github.com> Date: Thu, 6 Jun 2024 13:35:53 -0700 Subject: [PATCH 2/4] Fix default axis numbering --- .../aind_behavior_services/calibration/aind_manipulator.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/DataSchemas/aind_behavior_services/calibration/aind_manipulator.py b/src/DataSchemas/aind_behavior_services/calibration/aind_manipulator.py index 76048a61..e3cd9a8d 100644 --- a/src/DataSchemas/aind_behavior_services/calibration/aind_manipulator.py +++ b/src/DataSchemas/aind_behavior_services/calibration/aind_manipulator.py @@ -14,9 +14,9 @@ class Axis(IntEnum): """Motor axis available""" NONE = 0 - Y1 = 1 - Y2 = 2 - X = 3 + X = 1 + Y1 = 2 + Y2 = 3 Z = 4 From d26b6e68c7fb16dce86d9380d30966a67dc8eac5 Mon Sep 17 00:00:00 2001 From: bruno-f-cruz <7049351+bruno-f-cruz@users.noreply.github.com> Date: Thu, 6 Jun 2024 13:36:57 -0700 Subject: [PATCH 3/4] Regenerate schema --- .../schemas/aind_manipulator_calibration_rig.json | 10 +++++----- src/Extensions/AindManipulatorCalibrationRig.cs | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/DataSchemas/schemas/aind_manipulator_calibration_rig.json b/src/DataSchemas/schemas/aind_manipulator_calibration_rig.json index 81cf54cb..5863af76 100644 --- a/src/DataSchemas/schemas/aind_manipulator_calibration_rig.json +++ b/src/DataSchemas/schemas/aind_manipulator_calibration_rig.json @@ -83,7 +83,7 @@ "axis_configuration": { "default": [ { - "axis": 1, + "axis": 2, "step_acceleration_interval": 100, "step_interval": 100, "microstep_resolution": 0, @@ -93,7 +93,7 @@ "min_limit": -1 }, { - "axis": 2, + "axis": 3, "step_acceleration_interval": 100, "step_interval": 100, "microstep_resolution": 0, @@ -103,7 +103,7 @@ "min_limit": -1 }, { - "axis": 3, + "axis": 1, "step_acceleration_interval": 100, "step_interval": 100, "microstep_resolution": 0, @@ -131,9 +131,9 @@ }, "homing_order": { "default": [ - 1, 2, 3, + 1, 4 ], "items": { @@ -240,9 +240,9 @@ "type": "integer", "x-enumNames": [ "None", + "X", "Y1", "Y2", - "X", "Z" ] }, diff --git a/src/Extensions/AindManipulatorCalibrationRig.cs b/src/Extensions/AindManipulatorCalibrationRig.cs index 50bf1b05..c58d78fa 100644 --- a/src/Extensions/AindManipulatorCalibrationRig.cs +++ b/src/Extensions/AindManipulatorCalibrationRig.cs @@ -497,13 +497,13 @@ public enum Axis None = 0, [System.Runtime.Serialization.EnumMemberAttribute(Value="1")] - Y1 = 1, + X = 1, [System.Runtime.Serialization.EnumMemberAttribute(Value="2")] - Y2 = 2, + Y1 = 2, [System.Runtime.Serialization.EnumMemberAttribute(Value="3")] - X = 3, + Y2 = 3, [System.Runtime.Serialization.EnumMemberAttribute(Value="4")] Z = 4, From 5ad228ca8c128a6e138271de614c1fefbb21159e Mon Sep 17 00:00:00 2001 From: bruno-f-cruz <7049351+bruno-f-cruz@users.noreply.github.com> Date: Thu, 6 Jun 2024 13:37:47 -0700 Subject: [PATCH 4/4] Bump package version --- src/DataSchemas/aind_behavior_services/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DataSchemas/aind_behavior_services/__init__.py b/src/DataSchemas/aind_behavior_services/__init__.py index 3c7cff56..073af67f 100644 --- a/src/DataSchemas/aind_behavior_services/__init__.py +++ b/src/DataSchemas/aind_behavior_services/__init__.py @@ -1,4 +1,4 @@ -__version__ = "0.7.6" +__version__ = "0.7.7" from .rig import AindBehaviorRigModel from .session import AindBehaviorSessionModel