Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression Name Changes #1060

Closed
cyrush opened this issue Dec 2, 2022 · 2 comments
Closed

Expression Name Changes #1060

cyrush opened this issue Dec 2, 2022 · 2 comments
Labels
Milestone

Comments

@cyrush
Copy link
Member

cyrush commented Dec 2, 2022

Change ScalarGradient to be HistoryGradient in implementation and callable name to history_gradient

Change Replace to ArrayReplace in implementation.

Change ArrayGradient to HistoryGradientRange (?) in implementation. Think about naming for the interface.

@cyrush cyrush added the task label Dec 2, 2022
@cyrush
Copy link
Member Author

cyrush commented Dec 2, 2022

Also, should we have topology as an alias for topo ?
(in other expr funcs we have args named topology)

@cyrush cyrush added this to the 0.10.0 milestone Apr 8, 2023
@cyrush
Copy link
Member Author

cyrush commented Dec 5, 2023

resolved in #1167

@cyrush cyrush closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant