Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deployless so it works with the relayer #1319

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from

Conversation

borislav-itskov
Copy link
Member

Wrap _getConnection in a try/catch as not all RPCs have it.

Copy link
Member

@Ivshti Ivshti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few issues with this

  • if it fails, isProviderInvictus won't even be set - it will be a missing property; fix: initialize it to false beforehand
  • if it fails in an unexpected way, the error is swallowed; fix: instead of using try/catch, check if the property is there
  • there's a likelyhood that, in the RPC that DOES NOT have getConnection, it has ANOTHER method to get the URL
  • the fact that we have isProviderInvictus to begin with - behavior shouldn't depend on this. I'll review in detail

@Ivshti
Copy link
Member

Ivshti commented Feb 19, 2025

@borislav-itskov I take back/modify two feedbacks

  • the property is actually initialized, I didn't see that
  • isProviderInvictus only affects the timeouts which is fine, but I'd prefer that this is set on the top level from whoever uses the library, as the library user has more information on whether the provider is invictus and doesn't have to resort to hacks like checking the URL

@borislav-itskov
Copy link
Member Author

@borislav-itskov I take back/modify two feedbacks

  • the property is actually initialized, I didn't see that
  • isProviderInvictus only affects the timeouts which is fine, but I'd prefer that this is set on the top level from whoever uses the library, as the library user has more information on whether the provider is invictus and doesn't have to resort to hacks like checking the URL

We will discuss this with @PetromirDev and fix it

@PetromirDev PetromirDev self-requested a review February 19, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants