Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature / Mechanism to update network(s) config externally #1322

Draft
wants to merge 19 commits into
base: v2
Choose a base branch
from

Conversation

superKalo
Copy link
Member

@superKalo superKalo commented Feb 19, 2025

Tweaks for the predefined networks logic so that a new build is NOT needed when adding new network or changing an existing predefined network config. Moreover:

  • Separate predefined networks, custom networks, and user network preferences
  • Mechanism to override network config

Problems TODO solving:

  • Once a custom network is added, there's no mechanism to update the network-status-related config (pulled from the RPC). The only workaround for the user is to remove and add again the custom network. So figure out a sensible approach to regularly update those instead. Example: Imagine a custom network where areContractsDeployed was initially false, but then, someone deployed the contracts.

TODO:

  • Take the icons for all networks from the iconUrls (currently, for predefined networks, it's hardcoded)
  • Take the bundler API key from Relayer's network config (currently, they're in the .env file)

Relayer part coming in https://github.com/AmbireTech/relayer/pull/1037

Part of https://github.com/AmbireTech/ambire-app/issues/3840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants