Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement / Group Swap&Bridge Banners For In-progress and Complete #1333

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from

Conversation

gergana95
Copy link
Member

@gergana95 gergana95 commented Feb 25, 2025

Together with 4121

@gergana95 gergana95 added the enhancement New feature or request label Feb 25, 2025
@gergana95 gergana95 self-assigned this Feb 25, 2025
@gergana95 gergana95 changed the title Enhancement / Update Group Banners Enhancement / Group Swap&Bridge Banners For In-progress and Complete Feb 25, 2025
}
banners.push({
id: `bridge-${r.activeRouteId}`,
type: r.routeStatus === 'completed' ? 'success' : 'info',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can't be of type completed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kolega, are you sure? this was like that before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const remainingRoutes = filteredRoutes.filter(
(r) => r.routeStatus !== 'in-progress' && r.routeStatus !== 'completed'
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants